Dev minor

[emrgnt-cmplxty]

Important

This PR adds email reset and document metadata update features, updates API endpoints, and enhances document ingestion with collection ID support.

• Features:
  • Add sendResetEmail() to r2rClient in r2rClient.ts for sending reset emails.
  • Add updateDocumentMetadata() to r2rClient in r2rClient.ts for updating document metadata.
  • Add collection_ids support in r2rClient methods for document ingestion and updates.
• API Changes:
  • Add /send_reset_email and /update_document_metadata/{document_id} endpoints in auth_router.py and ingestion_router.py.
  • Add WrappedMetadataUpdateResponse to models/__init__.py and ingestion/responses.py.
• Database and Models:
  • Add send_reset_email method to auth.py and r2r_auth.py.
  • Add update_document_metadata method to ingestion_service.py.
  • Add collection_ids handling in ingestion_workflow.py and simple/ingestion_workflow.py.
• Miscellaneous:
  • Update package.json version to 0.3.14.
  • Fix import order in deduplication.py and kg.py.

^{This description was created by for 58bf088. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yc_demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 4, 2024 11:32pm
yc-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 4, 2024 11:32pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
recommendation_platform	⬜️ Ignored (Inspect)			Nov 4, 2024 11:32pm

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 58bf088 in 1 minute and 53 seconds

More details

• Looked at 1267 lines of code in 26 files
• Skipped 1 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. js/sdk/src/r2rClient.ts:478

• Draft comment:
  Avoid passing undefined explicitly as a parameter. It can lead to confusion and potential bugs. Consider removing it or providing a meaningful default value.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in r2rClient.ts and r2rClient.test.ts has a minor issue with the addition of an undefined parameter. This is not a good practice as it can lead to confusion and potential bugs. It would be better to explicitly name the parameter or remove it if not needed.

2. js/sdk/__tests__/r2rClient.test.ts:356

• Draft comment:
  Avoid passing undefined explicitly as a parameter. It can lead to confusion and potential bugs. Consider removing it or providing a meaningful default value.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in r2rClient.ts and r2rClient.test.ts has a minor issue with the addition of an undefined parameter. This is not a good practice as it can lead to confusion and potential bugs. It would be better to explicitly name the parameter or remove it if not needed.

Workflow ID: wflow_pmNBFwKN2Pelg1AP

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

This class duplicates the functionality of update_document_metadata in simple/ingestion_workflow.py. Consider refactoring to use the existing function.

• function update_document_metadata (ingestion_workflow.py)