Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up #1648

Merged
merged 1 commit into from
Dec 2, 2024
Merged

up #1648

merged 1 commit into from
Dec 2, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Dec 2, 2024

Important

Change table name from document to documents in SQL queries across multiple files for consistency.

  • Database Queries:
    • Change table name from document to documents in SQL queries in collection.py, user.py, and vector.py.
    • Affects functions like update_collection, delete_collection_relational, documents_in_collection, get_collections_overview, assign_document_to_collection_relational, remove_document_from_collection_relational, delete_user_relational, get_users_overview, search_documents, and others.
  • Consistency:
    • Ensures consistent table naming across the codebase.

This description was created by Ellipsis for 084f524. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review December 2, 2024 21:42
@emrgnt-cmplxty emrgnt-cmplxty merged commit 2e1ba7f into patch/alternative-up Dec 2, 2024
1 check passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 084f524 in 13 seconds

More details
  • Looked at 104 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/providers/database/collection.py:163
  • Draft comment:
    Ensure that the table name 'documents' is consistently used across the codebase to avoid runtime errors. This change is applied in multiple places in this file and others.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_UhR1sObhmeD4XALI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant