Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented upper and lower triangle methods in NumRuby #45

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/nmatrix/numruby.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,28 @@ def self.hstack(objs)
result
end

def self.tri(N, M=None, k=0, nm_dtype=float)
if M is None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that None is an object that you created. But I think that you can use nil instead of it. Also I think that isn't necessary use the : to the end of sentence. WDYT? 🤔

M = N

m = greater_equal.outer(arange(N, nm_dtype=nm_int(0, N)),
arange(-k, M-k, nm_dtype=nm_int(-k, M - k)))

# Avoid making a copy if the requested type is already bool
m = m.stype(nm_dtype, copy=False)
return m
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that missing and end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lines 72 to 76 are having extra indentation.

def tril(m, k=0)
m = Array(m)
mask = tri(*m.shape[-2:], k=k, nm_dtype=nm_bool)
return where(mask, m, zeros(1, m.nm_dtype))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this return isn't necessary 🤔

end

def triu(m, k=0)
m = Array(m)
mask = tri(*m.shape[-2:], k=k-1, nm_dtype=nm_bool)
return where(mask, zeros(1, m.nm_dtype), m)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this return isn't necessary 🤔

end

end