-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented upper and lower triangle methods in NumRuby #45
Changes from 1 commit
37dafe9
00405db
cec980d
a493439
a228101
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,4 +62,28 @@ def self.hstack(objs) | |
result | ||
end | ||
|
||
def self.tri(N, M=None, k=0, nm_dtype=float) | ||
if M is None: | ||
M = N | ||
|
||
m = greater_equal.outer(arange(N, nm_dtype=nm_int(0, N)), | ||
arange(-k, M-k, nm_dtype=nm_int(-k, M - k))) | ||
|
||
# Avoid making a copy if the requested type is already bool | ||
m = m.stype(nm_dtype, copy=False) | ||
return m | ||
end | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that missing and There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think lines |
||
def tril(m, k=0) | ||
m = Array(m) | ||
mask = tri(*m.shape[-2:], k=k, nm_dtype=nm_bool) | ||
return where(mask, m, zeros(1, m.nm_dtype)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this |
||
end | ||
|
||
def triu(m, k=0) | ||
m = Array(m) | ||
mask = tri(*m.shape[-2:], k=k-1, nm_dtype=nm_bool) | ||
return where(mask, zeros(1, m.nm_dtype), m) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this |
||
end | ||
|
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that
None
is an object that you created. But I think that you can usenil
instead of it. Also I think that isn't necessary use the:
to the end of sentence. WDYT? 🤔