Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4 Changed Dataframe little bit more Pandas style #5

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

dotChris90
Copy link
Member

  • corresponding to Should DataFrame really be a NDArray child? #4
  • be careful! there are a lot of changes
  • before you accept the request --> check the project separately maybe (https://github.com/dotChris90/Pandas.NET/tree/issue4)
  • the DataFrame class must contain 2 Generic types for the index type and value types
  • index type can be int, double, datetime, string (really everything if you look pandas in python)
  • value type is like in NDArray
  • Index must also be generic because it can be int, double, string and datetype (in python they write classes for this Datetimeindexclass, integerindexclass, ... we should use generics because this is C# strength)
  • since datas (columns) are accessed like column1 = df['column1'] I suggest we use a internal protected Dictionary (NDArray uses array for storage, dataframe shall use dictionary)
  • To verify all I adapted the unit Tests (they work - thats why i push ;) )

@Oceania2018 Oceania2018 merged commit 9710ac4 into SciSharp:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants