Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dds 1690 -- New cli command: dds project status extend #661

Merged
merged 36 commits into from
Oct 24, 2023

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Oct 17, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Added a new command in the client to match the endpoint of extendin the deadline

2. Jira task / GitHub issue

Link

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #661 (eaa7e4a) into dev (2d7cc6f) will increase coverage by 0.57%.
The diff coverage is 86.04%.

@@            Coverage Diff             @@
##              dev     #661      +/-   ##
==========================================
+ Coverage   47.68%   48.26%   +0.57%     
==========================================
  Files          31       31              
  Lines        2808     2851      +43     
==========================================
+ Hits         1339     1376      +37     
- Misses       1469     1475       +6     
Files Coverage Δ
dds_cli/project_status.py 66.97% <100.00%> (+12.54%) ⬆️
dds_cli/utils.py 97.43% <100.00%> (+0.02%) ⬆️
dds_cli/__main__.py 42.47% <45.45%> (+0.04%) ⬆️

@rv0lt rv0lt marked this pull request as ready for review October 17, 2023 13:54
@rv0lt rv0lt self-assigned this Oct 18, 2023
@rv0lt rv0lt requested a review from a team October 18, 2023 09:09
SPRINTLOG.md Outdated Show resolved Hide resolved
dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/__main__.py Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things noticed when testing

dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
rv0lt and others added 2 commits October 20, 2023 16:19
Co-authored-by: Ina Odén Österbo <[email protected]>
Co-authored-by: Ina Odén Österbo <[email protected]>
rv0lt and others added 3 commits October 20, 2023 16:20
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Show resolved Hide resolved
dds_cli/project_status.py Outdated Show resolved Hide resolved
dds_cli/project_status.py Show resolved Hide resolved
rv0lt and others added 5 commits October 23, 2023 12:50
Co-authored-by: Ina Odén Österbo <[email protected]>
Co-authored-by: Ina Odén Österbo <[email protected]>
Co-authored-by: Ina Odén Österbo <[email protected]>
Co-authored-by: Ina Odén Österbo <[email protected]>
@rv0lt rv0lt requested a review from i-oden October 23, 2023 12:53
dds_cli/project_status.py Outdated Show resolved Hide resolved
rv0lt and others added 2 commits October 23, 2023 17:10
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good, just need to add the error_message to the last request as well.

dds_cli/project_status.py Show resolved Hide resolved
Co-authored-by: Ina Odén Österbo <[email protected]>
@i-oden i-oden changed the title Dds 1690 new cli command dds project status extend Dds 1690 -- New cli command: dds project status extend Oct 24, 2023
dds_cli/project_status.py Outdated Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@rv0lt rv0lt merged commit 932963d into dev Oct 24, 2023
18 checks passed
@rv0lt rv0lt deleted the DDS-1690-New-CLI-command-dds-project-status-extend branch October 24, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants