Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version & changelog #667

Merged
merged 4 commits into from
Nov 22, 2023
Merged

New version & changelog #667

merged 4 commits into from
Nov 22, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Nov 13, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Add a summary of the changes in this PR and the related issue.

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@i-oden i-oden self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #667 (b06cfdf) into dev (6b5e204) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #667   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files          31       31           
  Lines        2887     2887           
=======================================
  Hits         1379     1379           
  Misses       1508     1508           
Files Coverage Δ
dds_cli/version.py 100.00% <100.00%> (ø)

@i-oden i-oden mentioned this pull request Nov 13, 2023
24 tasks
@valyo valyo marked this pull request as ready for review November 22, 2023 08:53
@valyo valyo merged commit c431ac3 into dev Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants