Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finished two testplans #5

Merged
merged 30 commits into from
Feb 2, 2024
Merged

Finished two testplans #5

merged 30 commits into from
Feb 2, 2024

Conversation

alfredeen
Copy link
Member

Finished test plans Normal and Classroom.
Also implemented non-Locust module to concurrently test opening user apps that create pods on the k8s cluster.

@alfredeen
Updated docs and config.
5b3d919
@alfredeen
Small change to instructions.
8af2e1a
@alfredeen
Refactored into using abstract base user types. These are implemented…
7dc91f1 
… in test plan scenario files.
@alfredeen
Added an app viewer user
0b74393
@alfredeen
Work on login to Serve as test user.
8f96c6f
@alfredeen
Completed authentication methods. Work on user type power user..
a180aeb
@alfredeen
Created non-locust module for opening user apps which created k8s pod…
991cbe1 
…s on cluster.
@alfredeen
More settings and configuration to customize the user app behaviour
16c6066
@alfredeen
Better handling of switching between test environments.
82e8720
@alfredeen
Added task to register new user account.
8286b6a
@alfredeen
Began test plan classroom. Implemented power user create and delete u…
0855d6a 
…ser project. Introduced new env var SERVE_LOCUST_DO_CREATE_OBJECTS.
@alfredeen
Finished test plan classroom.
0075962
@alfredeen alfredeen self-assigned this Jan 22, 2024
@alfredeen alfredeen marked this pull request as ready for review January 22, 2024 15:52
@alfredeen alfredeen requested a review from a team January 22, 2024 15:53
churnikov
churnikov approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@churnikov churnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I looked through it and tried to make a couple of comments. But I didn't really dig into the the code as I'm not that familiar with locust.

README.md Show resolved Hide resolved
source/locust-ui.conf Outdated Show resolved Hide resolved
source/tests-dev/appviewer_requestshtml.py Outdated Show resolved Hide resolved
source/tests-dev/appviewer_requestshtml.py Outdated Show resolved Hide resolved
source/tests-dev/appviewer_requestshtml.py Outdated Show resolved Hide resolved
source/tests-dev/appviewer_requestshtml.py Outdated Show resolved Hide resolved
source/tests-dev/appviewer_requestshtml.py Outdated Show resolved Hide resolved
source/tests-dev/appviewer_requestshtml.py Outdated Show resolved Hide resolved
source/tests-dev/appviewer_requestshtml.py Outdated Show resolved Hide resolved
source/tests-dev/authenticated.py Outdated Show resolved Hide resolved
alfredeen and others added 13 commits February 1, 2024 10:41
@alfredeen
Small change to readme to make configuration URL into a link.
3aad2da
@alfredeen
Added config files for pre-commit and flake8.
b4b3c42
@alfredeen
Added github workflow pre-commit
db19a75
@alfredeen @churnikov
Update source/tests-dev/appviewer_requestshtml.py
0ec1f15 
Co-authored-by: Nikita Churikov <[email protected]>
@alfredeen @churnikov
Update source/tests-dev/appviewer_requestshtml.py
01cc795 
Co-authored-by: Nikita Churikov <[email protected]>
@alfredeen @churnikov
Update source/tests-dev/appviewer_requestshtml.py
0d82d4c 
Co-authored-by: Nikita Churikov <[email protected]>
@alfredeen @churnikov
Update source/tests-dev/authenticated.py
b955402 
Co-authored-by: Nikita Churikov <[email protected]>
@alfredeen
Moved code check config files up to root level.
12b8fc9
@alfredeen
Reformatted with code linters and checkers
359a383
@alfredeen
Reformatted imports with isort
36c5c7f
@alfredeen
Reformatted and code changes for the mypy type checker.
b67f157
@alfredeen
Fixed end of line rules
626027c
@alfredeen
Introduced the standard logging library. Converted most prints to log…
046cdad 
…ging.
@alfredeen alfredeen requested a review from churnikov February 1, 2024 14:47
churnikov
churnikov reviewed Feb 1, 2024
View reviewed changes
pyproject.toml
name = "serve-load-testing"
version = "1.0.0"
description = "Load testing of the SciLifeLab Serve platform."
requires-python = "=3.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a new project, maybe let's use some newer version of python like 3.12?

source/tests/base_user_types.py Outdated Show resolved Hide resolved
source/tests/base_user_types.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@alfredeen alfredeen merged commit f555f80 into main Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@churnikov churnikov churnikov approved these changes

Assignees

@alfredeen alfredeen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfredeen @churnikov