Feature/kube event listener #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/kube-event-controller
alfredeen
reviewed
Nov 29, 2023
churnikov
reviewed
Nov 30, 2023
churnikov
approved these changes
Dec 1, 2023
…DataCentre/stackn into feature/kube-event-controller
churnikov
approved these changes
Dec 1, 2023
hamzaimran08
reviewed
Dec 4, 2023
| _ = delete_and_deploy_resource.delay(appinstance.pk, new_release_name) | ||
| else: | ||
| # Otherwise, we update the resources in the same helm release | ||
| _ = deploy_resource.delay(appinstance.pk, "update") |
There was a problem hiding this comment.
I haven't tested this yet but .delay() here is supposed to add this as a task in the queue for celery and not using it might just run it in the studio pod instead. Would be good to test if this is the case
There was a problem hiding this comment.
It adds the task to celery anyways, but the delay function just applies it asynchronously. But we should add delay here again. This is a mistake.
…DataCentre/stackn into feature/kube-event-controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As you know, the current functionality for updating the app status is far from optimal. This PR proposes a remake of this functionality by introducing an event listener. Instead of asking K8s if there has been a change, we now receive notifications that a change has been made.
The event listener is added as a celery task and fires up when celery is ready. It updates the appinstance state if a change has been made that either changed the state or if the app was deleted.
I've tested it and it works
serve-devChecklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!