Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional UI bugfixes #124

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Additional UI bugfixes #124

merged 6 commits into from
Jan 17, 2024

Conversation

akochari
Copy link
Collaborator

Description

This PR contains a few small bugfixes: SS-819, SS-837, SS-821, SS-779. These are related to subdomain addition, project names, and tags.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have updated the release notes (releasenotes.md)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@akochari akochari added the bug Something isn't working label Jan 12, 2024
sandstromviktor
sandstromviktor approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@sandstromviktor sandstromviktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Good job!

@akochari akochari merged commit c12d787 into develop Jan 17, 2024
3 checks passed
@akochari akochari deleted the ss-819-ui-bugfixes branch January 17, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandstromviktor sandstromviktor sandstromviktor approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akochari @sandstromviktor