Feature/minio file upload #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akochari
approved these changes
Jan 12, 2024
churnikov
reviewed
Jan 18, 2024
Comment on lines
+428
to
+432
| def generate_password(len: int) -> str: | ||
| return "".join( | ||
| secrets.choice(string.octdigits + string.ascii_uppercase + string.ascii_lowercase + string.digits) | ||
| for i in range(len) | ||
| ) |
There was a problem hiding this comment.
Why aren't you using django's password generator? I believe, that this way is most probably insecure and exploitable
Comment on lines
+23
to
+26
| except IntegrityError: | ||
| self.stdout.write(self.style.WARNING("User with the given username or email already exists.")) | ||
|
|
||
| self.stdout.write(self.style.SUCCESS(f"Successfully created {i} users")) |
There was a problem hiding this comment.
If IntegrityError is raised, then there should be less successful creations of users
|
|
||
|
|
||
| @register.filter | ||
| def dict_key(dictionary, key): |
There was a problem hiding this comment.
A couple of words about what is that would have helped understand its purpose. I feel like I get it, but still
On minio bucket creation date looks weird
Is there a way to see how much storage is given to me? I also feel like I don't understand the time limit? What would happen to data afterwards? Tried to use s3 via api. Didn't work for me |
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ok, this is a big one. Sorry about that.
The main goal was to enable users to upload files in a simple manner. We decided that minio does the job.
After this PR, you can upload files with Minio using the S3-API and the UI.
How to test? Right now, this is up and running on serve-dev, so please go there and test it in different ways.
What have i done?
In addition: To help with the locust tests, i've made 5 django admin commands that populate the database with temp users, projects and apps. This should probably be a separate PR, but i included it so i could test it on dev simultaneously with the file manage part.
Let me know what you think!
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.