Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] shared-recovery create: make threshold optional if recipients is not specified #9087

Open
AureliaDolo opened this issue Dec 2, 2024 · 1 comment · Fixed by #9127
Open
Assignees
Labels
enhancement Improve functionality, potentially changing behavior I-CLI Impact: Command-line interface I-Rust Impact: Rust-related stuff

Comments

@AureliaDolo
Copy link
Contributor

Threshold arg should not be required when recipients are not specified (it should have the same requires = "recipients", as weights)

Default recipients are all admins expect author.

Default for threshold could be

  • max(1, ⌊admin_count * k⌋) with k between 0 and 1.

What should be k default value, should it be configurable ? (no)

I'd rather go for 2/3

@mmmarcos mmmarcos added I-Rust Impact: Rust-related stuff I-CLI Impact: Command-line interface labels Dec 4, 2024
@mmmarcos mmmarcos changed the title [CLI] shared-recovery create: make threshold optional [CLI] shared-recovery create: make threshold optional if recipients is not specified Dec 4, 2024
@mmmarcos
Copy link
Contributor

mmmarcos commented Dec 4, 2024

Discussed with @vxgmichel and @touilleMan: instead of having a default threshold, the CLI could prompt the user for the threshold value to be used.

@mmmarcos mmmarcos added the enhancement Improve functionality, potentially changing behavior label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve functionality, potentially changing behavior I-CLI Impact: Command-line interface I-Rust Impact: Rust-related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants