Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli shared recovery create - ask for threshold if not provided. #9127

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Cli shared recovery create - ask for threshold if not provided. #9127

merged 4 commits into from
Dec 10, 2024

Conversation

AureliaDolo
Copy link
Contributor

Fix #9087

@AureliaDolo AureliaDolo linked an issue Dec 6, 2024 that may be closed by this pull request
[CLI] shared-recovery create: make threshold optional if recipients is not specified #9087
Open
@AureliaDolo AureliaDolo force-pushed the aurelia/cli/shared_recovery_create_threshold branch from c9dea47 to 703380d Compare December 6, 2024 10:38
@AureliaDolo AureliaDolo marked this pull request as ready for review December 6, 2024 13:15
@AureliaDolo AureliaDolo requested a review from a team as a code owner December 6, 2024 13:15
FirelightFlagboy
FirelightFlagboy reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the threshold input ?

vxgmichel
vxgmichel approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single comment, LGTM otherwise 👍

cli/src/commands/shared_recovery/create.rs
.with_prompt(format!(
"Choose a threshold between 1 and {}\nThe threshold is the minimum number of recipients that one must gather to recover the account",
per_recipient_shares.len()
)) .interact_text()?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a blocking sync call in an async function, we should at least acknowledge it with a comment

@AureliaDolo AureliaDolo force-pushed the aurelia/cli/shared_recovery_create_threshold branch from 8310ee9 to a68c67f Compare December 9, 2024 14:01
@AureliaDolo AureliaDolo mentioned this pull request Dec 9, 2024
Open
2 tasks
@AureliaDolo AureliaDolo force-pushed the aurelia/cli/shared_recovery_create_threshold branch from a68c67f to 1bc2174 Compare December 9, 2024 14:35
@AureliaDolo AureliaDolo merged commit 982ec52 into aurelia/cli/shamir Dec 10, 2024
0 of 2 checks passed
@AureliaDolo AureliaDolo deleted the aurelia/cli/shared_recovery_create_threshold branch December 10, 2024 16:23
AureliaDolo added a commit that referenced this pull request Dec 10, 2024
@AureliaDolo
Cli shared recovery create - ask for threshold if not provided. (#9127)
08c10f6 
* Cli shared recovery create - ask for threshold if not provided.

* CLI shared recovery create - add test for interactive threshold

* [CLI] rework spinners and display for shared recovery.
AureliaDolo added a commit that referenced this pull request Dec 12, 2024
@AureliaDolo
Cli shared recovery create - ask for threshold if not provided. (#9127)
e516819 
* Cli shared recovery create - ask for threshold if not provided.

* CLI shared recovery create - add test for interactive threshold

* [CLI] rework spinners and display for shared recovery.
AureliaDolo added a commit that referenced this pull request Dec 12, 2024
@AureliaDolo
Cli shared recovery create - ask for threshold if not provided. (#9127)
bcd8714 
* Cli shared recovery create - ask for threshold if not provided.

* CLI shared recovery create - add test for interactive threshold

* [CLI] rework spinners and display for shared recovery.
AureliaDolo added a commit that referenced this pull request Dec 16, 2024
@AureliaDolo
Cli shared recovery create - ask for threshold if not provided. (#9127)
48291e7 
* Cli shared recovery create - ask for threshold if not provided.

* CLI shared recovery create - add test for interactive threshold

* [CLI] rework spinners and display for shared recovery.
AureliaDolo added a commit that referenced this pull request Dec 16, 2024
@AureliaDolo
Cli shared recovery create - ask for threshold if not provided. (#9127)
818f764 
* Cli shared recovery create - ask for threshold if not provided.

* CLI shared recovery create - add test for interactive threshold

* [CLI] rework spinners and display for shared recovery.
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
@AureliaDolo
Cli shared recovery create - ask for threshold if not provided. (#9127)
739951b 
* Cli shared recovery create - ask for threshold if not provided.

* CLI shared recovery create - add test for interactive threshold

* [CLI] rework spinners and display for shared recovery.
@mmmarcos mmmarcos mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FirelightFlagboy FirelightFlagboy FirelightFlagboy approved these changes

@vxgmichel vxgmichel vxgmichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI] shared-recovery create: make threshold optional if recipients is not specified
3 participants
@AureliaDolo @vxgmichel @FirelightFlagboy