Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shamir port] Implement greeting procedure #8995

Merged
merged 27 commits into from
Dec 12, 2024
Merged

[Shamir port] Implement greeting procedure #8995

merged 27 commits into from
Dec 12, 2024

Conversation

vxgmichel
Copy link
Contributor

@vxgmichel vxgmichel commented Nov 25, 2024 •
edited
Loading

Close #8841

TODO:

  • more tests
  • proper error handling
  • greeter detects when the device is not recoverable due to too many recipients revoked
  • claimer detects when the device is not recoverable due to too many recipients being revoked

@vxgmichel vxgmichel force-pushed the issue-8841 branch 2 times, most recently from 08dde62 to d8d9e29 Compare November 29, 2024 12:35
@vxgmichel vxgmichel marked this pull request as ready for review November 29, 2024 12:47
@vxgmichel vxgmichel requested review from a team as code owners November 29, 2024 12:47
@vxgmichel vxgmichel force-pushed the issue-8841 branch 2 times, most recently from 4c9ff67 to 668467a Compare December 2, 2024 13:06
@FirelightFlagboy FirelightFlagboy marked this pull request as draft December 2, 2024 15:29
@vxgmichel vxgmichel mentioned this pull request Dec 3, 2024
Merged
@vxgmichel vxgmichel force-pushed the issue-8841 branch 5 times, most recently from 63b59c6 to b03ba23 Compare December 10, 2024 16:06
@vxgmichel vxgmichel marked this pull request as ready for review December 11, 2024 10:19
@vxgmichel vxgmichel requested a review from a team as a code owner December 11, 2024 10:19
touilleMan
touilleMan requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests for Client::start_shamir_recovery_invitation_greet are missing (but that's basically just renaming libparsec/crates/client/tests/unit/client/shamir_recovery_get_share_data.rs)

server/parsec/components/memory/invite.py Outdated Show resolved Hide resolved
server/parsec/components/memory/invite.py Show resolved Hide resolved
server/parsec/components/memory/invite.py Outdated Show resolved Hide resolved
libparsec/crates/protocol/schema/invited_cmds/invite_shamir_recovery_reveal.json5 Outdated Show resolved Hide resolved
misc/gen_protocol_typings.py Outdated Show resolved Hide resolved
libparsec/crates/client/src/invite/claimer.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/shamir_recovery_list.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/shamir_recovery_list.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/shamir_recovery_list.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/invite/claimer.rs Show resolved Hide resolved
@vxgmichel vxgmichel requested a review from touilleMan December 11, 2024 16:48
@vxgmichel vxgmichel force-pushed the issue-8841 branch 3 times, most recently from cf08d0a to 618a657 Compare December 11, 2024 18:24
FirelightFlagboy
FirelightFlagboy previously requested changes Dec 12, 2024
View reviewed changes
cli/src/commands/invite/claim.rs Outdated Show resolved Hide resolved
@vxgmichel
Implement ShamirRecoveryClaimRecoverDeviceCtx::recover_device
803ff49
@vxgmichel
Complete the shamir recovery invitation after the local device has be…
b24e862 
…en saved
@vxgmichel
Fix PreventSyncPattern after rebase
7e90d8d
@vxgmichel
Use NonZeroU8 in shamir rfc
8fde035
@vxgmichel
Rename UserOrDeviceClaimInitialCtx to AnyClaimRetrievedInfoCtx
8a2cd56
@vxgmichel
Specialize errors in shamir_recovery_list module
1076f7c
@vxgmichel
Add proper error handling to get_shamir_recovery_share_data
0a3a81b
@vxgmichel
Add dedicated errors for ShamirRecoveryClaim specific contexts
865223e
@vxgmichel
Log errors if the shamir recovery invitation deletion fails after the…
694df68 
… device has been saved
@vxgmichel
Add revoked_on field to ShamirRecoveryRecipient
8740383
@vxgmichel
Improve test_invited_invite_info_ok_with_shamir
2cdba06
@vxgmichel
Add revoked recipient to shamir client test
a68cea0
@vxgmichel
Fix connection error handling for invited cmds
424d2c2
@vxgmichel
Add more shamir greeting tests
85e9b4e
@vxgmichel
Address @touilleMan's comments about invite_shamir_recovery_reveal
8f648c9
@vxgmichel
Add utils module for invite unit testing
408a80b
@vxgmichel
Bump testbed server
22e0f53
@vxgmichel
Do not expose shamir_recovery_get_share_data
44f1e7d
@vxgmichel
Address @touilleMan's comments about claimer module
9daa596
@vxgmichel
Address @touilleMan's comments about get_shamir_recovery_share_data i…
01d6818 
…mplementation
@vxgmichel
Rename AlreadyUsed to AlreadyUsedOrDeleted
18e7bf1
@vxgmichel
Add more tests to shamir recovery invite
d1ccac0
@vxgmichel
Address @FirelightFlagboy comment about panic vs errors for todos in …
40484fa 
…the CLI
@vxgmichel
Remove user_id fields in CertifGetShamirRecoveryShareDataError variants
58b8125
@vxgmichel
Remove useless pub in client module
1774498
@vxgmichel vxgmichel added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 515c5ca Dec 12, 2024
16 checks passed
@vxgmichel vxgmichel deleted the issue-8841 branch December 12, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureliaDolo AureliaDolo AureliaDolo left review comments

@FirelightFlagboy FirelightFlagboy FirelightFlagboy left review comments

@touilleMan touilleMan touilleMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Shamir port] Implement greeting procedure
4 participants
@vxgmichel @touilleMan @FirelightFlagboy @AureliaDolo