Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Update invoice translations #9097

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MS] Update invoice translations #9097

wants to merge 1 commit into from

Conversation

fabienSvtr
Copy link
Contributor

@fabienSvtr fabienSvtr commented Dec 3, 2024 •
edited
Loading

Describe your changes

Translation updated:

  • Date
  • Status
image

Checklist

Before you submit this pull request, please make sure to:

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description

closes #8731
closes #8732

@fabienSvtr fabienSvtr requested a review from a team as a code owner December 3, 2024 10:50
NicoTuxx
NicoTuxx requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@NicoTuxx NicoTuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is not fixing every problem described in the linked issues: the icon alignment bug is still present.

image
image

client/src/services/translation.ts Outdated Show resolved Hide resolved
@fabienSvtr fabienSvtr changed the title [MS] Update invoice traductions [MS] Update invoice translations Dec 4, 2024
@Scille Scille deleted a comment from NicoTuxx Dec 4, 2024
@fabienSvtr fabienSvtr force-pushed the ms-update-invoice-traductions branch from f5ba6ed to 3d0985f Compare December 4, 2024 06:23
Max-7
Max-7 requested changes Dec 4, 2024
View reviewed changes
client/src/locales/fr-FR.json Outdated Show resolved Hide resolved
client/src/locales/fr-FR.json Outdated Show resolved Hide resolved
client/src/services/translation.ts Outdated Show resolved Hide resolved
@fabienSvtr fabienSvtr force-pushed the ms-update-invoice-traductions branch 3 times, most recently from c64ce32 to 63d11c7 Compare December 5, 2024 14:18
@fabienSvtr fabienSvtr force-pushed the ms-update-invoice-traductions branch from dbfe3d3 to 956bec6 Compare December 9, 2024 11:00
@fabienSvtr
Copy link
Contributor Author

The PR is not fixing every problem described in the linked issues: the icon alignment bug is still present.

image image

As discussed, I replaced the download icon, now included in megashark-lib.

@fabienSvtr fabienSvtr force-pushed the ms-update-invoice-traductions branch 2 times, most recently from c668d7a to 22eb90e Compare December 11, 2024 10:37
@fabienSvtr fabienSvtr force-pushed the ms-update-invoice-traductions branch from 22eb90e to e5aa89c Compare December 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx requested changes

@Max-7 Max-7 Max-7 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Customer area] Invoices page table problems [Customer area] Dashboard's last invoices table problems
3 participants
@fabienSvtr @Max-7 @NicoTuxx