Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Catch errors when initializing the electron updater #9164

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[MS] Catch errors when initializing the electron updater #9164

merged 1 commit into from
Dec 11, 2024

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Dec 11, 2024

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes

@Max-7 Max-7 requested a review from a team as a code owner December 11, 2024 13:19
NicoTuxx
NicoTuxx approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@NicoTuxx NicoTuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Max-7 Max-7 added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit d1e7bf6 Dec 11, 2024
13 checks passed
@Max-7 Max-7 deleted the ms-try-catch-updater branch December 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Max-7 @NicoTuxx