Add missing shamir recovery GUI bindings #9319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vxgmichel
force-pushed
the
shamir-bindings
branch
5 times, most recently
from
3c7a196 to
5eeac66
Compare
…ir_recoveries_for_others
vxgmichel
force-pushed
the
shamir-bindings
branch
from
5eeac66 to
9d1450e
Compare
vxgmichel
force-pushed
the
shamir-bindings
branch
2 times, most recently
from
3d982d0 to
4d916e5
Compare
vxgmichel
force-pushed
the
shamir-bindings
branch
from
4d916e5 to
b9ae1a8
Compare
| @@ -14,6 +14,8 @@ | |||
| JsObject | |||
| {%- elif type.kind == "list" -%} | |||
| JsArray | |||
| {%- elif type.kind == "set" -%} | |||
| JsArray | |||
There was a problem hiding this comment.
suggestion: Ideally, we should be using JsSet but that type is not exposed in neon, that would require to do something similar to Map
There was a problem hiding this comment.
Yes we did consider it. But as you pointed out, the code for Map conversion is quite tricky since it requires to use neon::reflect::eval. Since we don't know yet whether we really need Set representation on the JS side, we decided to stick with Array for now and change it later if necessary.
touilleMan
approved these changes
Jan 15, 2025
Max-7
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8998