Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mountpoint issues on macOS #9351

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Fix mountpoint issues on macOS #9351

merged 4 commits into from
Jan 17, 2025

Conversation

FirelightFlagboy
Copy link
Contributor

No description provided.

@FirelightFlagboy FirelightFlagboy requested a review from a team as a code owner January 16, 2025 08:13
@FirelightFlagboy FirelightFlagboy force-pushed the 8907-macos-mounpoint-issue branch from 85ad273 to 0133947 Compare January 16, 2025 08:22
This was linked to issues Jan 16, 2025
[↩️ Backport][🐛 Bug]: [MacOS] Cannot drop file to finder folder of mountpoint #9173
Closed
[🐛 | Bug]: MacOS: file saving not working from native MacOS software #8991
Closed
[🐛 | Bug]: Copy/paste on macOS mountpoint not working #8976
Closed
@FirelightFlagboy FirelightFlagboy force-pushed the 8907-macos-mounpoint-issue branch from 0133947 to 9c4c746 Compare January 16, 2025 08:45
touilleMan
touilleMan reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test, that would rely on a subprocess running your snippet of osascript

(typically put in libparsec/crates/platform_mountpoint/tests/unit/operations/unix_setattr.rs)

And we also need some linux tests given the code change impact them too (and besides there is no tests for setattr right now !)

For instances:

  • macos only test with osascript the copy of a file
  • (linux, macos) test setattr used for truncate to an arbitrary size (same size as current one, bigger size, smaller size, zero size)
  • (linux, macos) test setattr used to change the others fields allowed by it but not supported (atime, etc.)
  • (linux, macos) test setattr on a non-existing file
  • (linux, macos) test setattr to change size on a folder

Obviously we can create an issue to implement part of them in a separated PR

deny.toml Show resolved Hide resolved
libparsec/crates/platform_mountpoint/src/unix/filesystem.rs Show resolved Hide resolved
libparsec/crates/platform_mountpoint/src/unix/filesystem.rs Outdated Show resolved Hide resolved
libparsec/crates/platform_mountpoint/src/unix/filesystem.rs Show resolved Hide resolved
libparsec/crates/platform_mountpoint/src/unix/filesystem.rs Show resolved Hide resolved
@FirelightFlagboy FirelightFlagboy mentioned this pull request Jan 16, 2025
Open
5 tasks
@mmmarcos
Copy link
Contributor

@FirelightFlagboy this PR fixes multiple issues (#8976, #8991, #9173) but it is not clearly specified which changes fix which issues. Please summarize it in the PR description.

@FirelightFlagboy
Copy link
Contributor Author

@FirelightFlagboy this PR fixes multiple issues (#8976, #8991, #9173) but it is not clearly specified which changes fix which issues. Please summarize it in the PR description.

Those are specified in the body of the first 2 commits

@FirelightFlagboy FirelightFlagboy force-pushed the 8907-macos-mounpoint-issue branch from 8c9c40c to 4f057ec Compare January 16, 2025 10:20
@FirelightFlagboy
Copy link
Contributor Author

Can you add a test, that would rely on a subprocess running your snippet of osascript [...]

I've created the issue #9353

@FirelightFlagboy FirelightFlagboy force-pushed the 8907-macos-mounpoint-issue branch from 4f057ec to 1b0a71a Compare January 16, 2025 10:27
@FirelightFlagboy FirelightFlagboy force-pushed the 8907-macos-mounpoint-issue branch from 1b0a71a to 331a92d Compare January 17, 2025 09:30
@mmmarcos
Copy link
Contributor

Can you add a test, that would rely on a subprocess running your snippet of osascript [...]

I've created the issue #9353

I'd still add some tests in this PR because it fixes major bugs. IMO we should add at least test regarding unix_setattr.rs.

@mmmarcos mmmarcos removed their request for review January 17, 2025 13:23
@vxgmichel vxgmichel merged commit 0467065 into releases/3.2 Jan 17, 2025
12 checks passed
@vxgmichel vxgmichel deleted the 8907-macos-mounpoint-issue branch January 17, 2025 14:58
This was referenced Jan 17, 2025
Closed
Closed
Closed
Merged
FirelightFlagboy added a commit that referenced this pull request Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
d4bc2ba 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this pull request Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
bdaef8f 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this pull request Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
9f3a2dd 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this pull request Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
5c10273 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
a901b68 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
0af9419 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmmarcos mmmarcos mmmarcos left review comments

@touilleMan touilleMan touilleMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@FirelightFlagboy @mmmarcos @touilleMan @vxgmichel