Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Ask for confirmation before creating shared recovery. #9370

Merged
merged 2 commits into from
Jan 27, 2025
Merged

[CLI] Ask for confirmation before creating shared recovery. #9370

merged 2 commits into from
Jan 27, 2025

Conversation

AureliaDolo
Copy link
Contributor

Fix #9125

@AureliaDolo AureliaDolo marked this pull request as ready for review January 17, 2025 15:45
@AureliaDolo AureliaDolo requested a review from a team as a code owner January 17, 2025 15:45
@AureliaDolo AureliaDolo force-pushed the aurelia/cli/confirm_shamir_creation branch from 523e361 to 14157ce Compare January 17, 2025 15:46
vxgmichel
vxgmichel approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, LGTM otherwise 👍

cli/src/commands/shared_recovery/create.rs Outdated Show resolved Hide resolved
cli/src/commands/shared_recovery/create.rs Outdated Show resolved Hide resolved
@AureliaDolo AureliaDolo force-pushed the aurelia/cli/confirm_shamir_creation branch 2 times, most recently from a748596 to c69ea7a Compare January 20, 2025 13:26
@AureliaDolo AureliaDolo force-pushed the aurelia/cli/confirm_shamir_creation branch from fff41a1 to 0e9742b Compare January 27, 2025 13:26
@AureliaDolo AureliaDolo enabled auto-merge January 27, 2025 13:26
@AureliaDolo AureliaDolo added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit dbda62a Jan 27, 2025
14 checks passed
@AureliaDolo AureliaDolo deleted the aurelia/cli/confirm_shamir_creation branch January 27, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vxgmichel vxgmichel vxgmichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI] shared recovery create: prompt to confirm
2 participants
@AureliaDolo @vxgmichel