Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winfsp fix write operations on read only workspace #9391

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

touilleMan
Copy link
Member

No description provided.

@touilleMan touilleMan requested a review from a team as a code owner January 20, 2025 16:01
vxgmichel

This comment was marked as outdated.

@vxgmichel vxgmichel added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@vxgmichel vxgmichel added this pull request to the merge queue Jan 20, 2025
@vxgmichel vxgmichel removed this pull request from the merge queue due to a manual request Jan 20, 2025
@vxgmichel vxgmichel self-requested a review January 20, 2025 16:46
Copy link
Contributor

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a regression for existing dialogs

image

became:

image

@touilleMan touilleMan force-pushed the winfsp-fix-write-operations-on-read-only-workspace branch 2 times, most recently from f490812 to 8d31791 Compare January 20, 2025 17:53
Copy link
Contributor

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@touilleMan touilleMan force-pushed the winfsp-fix-write-operations-on-read-only-workspace branch from afb397e to 9643cc7 Compare January 20, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants