Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add orphaned diff finder #228

Merged
merged 1 commit into from
Jan 3, 2025
Merged

add orphaned diff finder #228

merged 1 commit into from
Jan 3, 2025

Conversation

TroyKomodo
Copy link
Member

Adds a github action that finds differences in PRs that are not in the final PR diff.

For example if

Commit A adds random.bin
Commit B removes random.bin
Commit C changes x.py

The final PR diff will only show the changes for x.py and the random.bin addition and removal will not be shown. This action finds and reports those and other line diffs so that we can understand if something has been secretly inserted into git history.

Copy link

github-actions bot commented Jan 3, 2025

No orphaned changes found.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 11.44998% with 5081 lines in your changes missing coverage. Please review.

Project coverage is 12.36%. Comparing base (71ced97) to head (1369256).
Report is 11 commits behind head on main.

Current head 1369256 differs from pull request most recent head bbf08c7

Please upload reports for the commit bbf08c7 to get more accurate results.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/ffmpeg/src/encoder.rs 0.00% 479 Missing ⚠️
crates/http/src/error.rs 0.00% 251 Missing ⚠️
crates/bootstrap/telemetry/src/lib.rs 0.00% 236 Missing ⚠️
crates/http/src/backend/tcp/config.rs 0.00% 204 Missing ⚠️
crates/h3-webtransport/src/session.rs 0.00% 199 Missing ⚠️
crates/ffmpeg/src/io/output.rs 0.00% 193 Missing ⚠️
crates/h3-webtransport/src/server.rs 0.00% 191 Missing ⚠️
crates/http/src/backend/tcp/serve.rs 0.00% 190 Missing ⚠️
crates/ffmpeg/src/io/internal.rs 0.00% 179 Missing ⚠️
crates/http/src/backend/quic/quinn/config.rs 0.00% 177 Missing ⚠️
... and 41 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   13.86%   12.36%   -1.51%     
==========================================
  Files          54       63       +9     
  Lines        6244     7149     +905     
  Branches       98        0      -98     
==========================================
+ Hits          866      884      +18     
- Misses       5360     6265     +905     
+ Partials       18        0      -18     
Files with missing lines Coverage Δ
crates/batching/src/batch.rs 100.00% <100.00%> (+2.73%) ⬆️
crates/batching/src/dataloader.rs 100.00% <100.00%> (+2.63%) ⬆️
crates/metrics/src/collector.rs 0.00% <ø> (ø)
crates/metrics/src/prometheus/mod.rs 0.00% <ø> (ø)
crates/metrics/src/value.rs 60.74% <ø> (ø)
crates/postcompile/src/deps.rs 0.00% <ø> (ø)
crates/postcompile/src/features.rs 0.00% <ø> (ø)
crates/postcompile/src/lib.rs 0.00% <ø> (ø)
crates/pprof/src/cpu.rs 0.00% <ø> (ø)
crates/settings/src/lib.rs 0.00% <ø> (ø)
... and 53 more
Components Coverage Δ
scuffle-batching 100.00% <100.00%> (+2.68%) ⬆️
scuffle-bootstrap 27.15% <18.51%> (ø)
scuffle-context 0.00% <0.00%> (ø)
scuffle-ffmpeg 0.00% <0.00%> (ø)
scuffle-h3-webtransport 0.00% <0.00%> (ø)
scuffle-http 0.00% <0.00%> (ø)
scuffle-metrics 42.46% <68.51%> (-1.19%) ⬇️
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 43.41% <ø> (+1.55%) ⬆️
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

@TroyKomodo
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 3, 2025

📌 Commit bbf08c7 has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by:

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 3, 2025

⌛ Trying commit bbf08c7 with merge 556351c...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 3, 2025

🎉 Build successful!
Completed in 2:00

Approved by:
Pushing 556351c to main

@scuffle-brawl scuffle-brawl bot merged commit 556351c into main Jan 3, 2025
8 checks passed
@scuffle-brawl scuffle-brawl bot deleted the troy/orphaned branch January 3, 2025 22:20
TroyKomodo added a commit to ScuffleCloud/brawl that referenced this pull request Jan 3, 2025
Adds an orphaned changes check from ScuffleCloud/scuffle#228
scuffle-brawl bot added a commit to ScuffleCloud/brawl that referenced this pull request Jan 3, 2025
add orphans check
Adds an orphaned changes check from ScuffleCloud/scuffle#228

Requested-by: TroyKomodo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant