Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc tests #232

Merged
merged 4 commits into from
Jan 5, 2025
Merged

fix: doc tests #232

merged 4 commits into from
Jan 5, 2025

Conversation

lennartkloock
Copy link
Member

  • Fix all existing doc tests

@lennartkloock
Copy link
Member Author

?brawl try

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

⌛ Trying commit f8c255d with merge 905dffb...

scuffle-brawl bot added a commit that referenced this pull request Jan 5, 2025
fix: doc tests
- Fix all existing doc tests

Requested-by: lennartkloock <[email protected]>
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 77.36571% with 2069 lines in your changes missing coverage. Please review.

Project coverage is 48.91%. Comparing base (556351c) to head (005b8ca).
Report is 19 commits behind head on main.

Current head 005b8ca differs from pull request most recent head e880d1d

Please upload reports for the commit e880d1d to get more accurate results.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/mp4/src/codec.rs 25.86% 129 Missing ⚠️
crates/av1/src/obu/seq.rs 51.58% 122 Missing ⚠️
crates/h265/src/sps.rs 62.19% 93 Missing ⚠️
crates/mp4/src/boxes/types/stz2.rs 0.00% 90 Missing ⚠️
crates/mp4/src/boxes/types/trun.rs 69.79% 90 Missing ⚠️
crates/mp4/src/boxes/types/subs.rs 0.00% 81 Missing ⚠️
crates/mp4/src/boxes/types/traf.rs 61.66% 69 Missing ⚠️
crates/mp4/src/boxes/types/sbgp.rs 0.00% 62 Missing ⚠️
crates/mp4/src/boxes/types/tfhd.rs 65.62% 55 Missing ⚠️
crates/mp4/src/boxes/types/hmhd.rs 0.00% 49 Missing ⚠️
... and 82 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #232       +/-   ##
===========================================
+ Coverage   12.36%   48.91%   +36.54%     
===========================================
  Files          63      199      +136     
  Lines        7149    16329     +9180     
===========================================
+ Hits          884     7987     +7103     
- Misses       6265     8342     +2077     
Files with missing lines Coverage Δ
crates/aac/src/tests.rs 100.00% <100.00%> (ø)
crates/amf0/src/define.rs 100.00% <100.00%> (ø)
crates/amf0/src/errors.rs 100.00% <100.00%> (ø)
crates/amf0/src/tests.rs 100.00% <100.00%> (ø)
crates/av1/src/tests.rs 100.00% <100.00%> (ø)
crates/bytesio/src/bytesio_errors.rs 100.00% <100.00%> (ø)
crates/context/src/lib.rs 0.00% <ø> (ø)
crates/exp_golomb/src/lib.rs 100.00% <100.00%> (ø)
crates/exp_golomb/src/tests.rs 100.00% <100.00%> (ø)
crates/h264/src/tests.rs 100.00% <100.00%> (ø)
... and 128 more
Components Coverage Δ
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 27.15% <ø> (ø)
scuffle-context 0.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <ø> (ø)
scuffle-metrics 42.46% <ø> (ø)
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 43.41% <ø> (ø)
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

🎉 Try build successful!
Completed in 7:43

Requested by: @lennartkloock
Build commit: 905dffb (905dffb2160c17c04ce374f393f9216569bfc5e0)

@lennartkloock
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

📌 Commit e880d1d has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @TroyKomodo

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

⌛ Trying commit e880d1d with merge b22c2b9...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

🎉 Build successful!
Completed in 8:16

Approved by: @TroyKomodo
Pushing b22c2b9 to main

@scuffle-brawl scuffle-brawl bot merged commit b22c2b9 into main Jan 5, 2025
7 checks passed
@scuffle-brawl scuffle-brawl bot deleted the lennart/fix-doctests branch January 5, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants