Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes doc testing in CI #233

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fixes doc testing in CI #233

merged 1 commit into from
Jan 5, 2025

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented Jan 5, 2025

Fix a cache issue with doc tests and enable them with ci.

We remove branch coverage here, unfortunately branch coverage is a bit broken. We will have to remove it anyways because it does not work with diesel. Noted by llvm/llvm-project#119558, disabling it now is fine. I hope we can enable it later at somepoint to get back the branch coverage.

Fix a cache issue with doc tests and enable them with ci
@lennartkloock
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

📌 Commit 13e77a0 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @lennartkloock

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

⌛ Trying commit 13e77a0 with merge e4800b4...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 5, 2025

🎉 Build successful!
Completed in 1:32

Approved by: @lennartkloock
Pushing e4800b4 to main

@scuffle-brawl scuffle-brawl bot merged commit e4800b4 into main Jan 5, 2025
6 checks passed
@scuffle-brawl scuffle-brawl bot deleted the troy/fix-testing-ci branch January 5, 2025 19:09
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.91%. Comparing base (b22c2b9) to head (ddd0d97).
Report is 2 commits behind head on main.

Current head ddd0d97 differs from pull request most recent head 13e77a0

Please upload reports for the commit 13e77a0 to get more accurate results.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   48.91%   48.91%           
=======================================
  Files         199      199           
  Lines       16329    16329           
=======================================
  Hits         7987     7987           
  Misses       8342     8342           
Components Coverage Δ
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 27.15% <ø> (ø)
scuffle-context 0.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <ø> (ø)
scuffle-metrics 42.46% <ø> (ø)
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 43.41% <ø> (ø)
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants