add future-ext #234
Merged
add future-ext #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TroyKomodo
force-pushed
the
troy/future-ext
branch
2 times, most recently
from
9fdc26d to
9fb9873
Compare
TroyKomodo
force-pushed
the
troy/future-ext
branch
from
9fb9873 to
8b5bc9b
Compare
TroyKomodo
force-pushed
the
troy/future-ext
branch
from
8b5bc9b to
fb1b83a
Compare
lennartkloock
approved these changes
Jan 5, 2025
I find the syntax for `tokio::time::timeout` to be quite ugly, since it breaks the typical chained method calls. With the FutureExt trait we can just call `.with_timeout(..)` instead which seems to be a cleaner way to do it.
TroyKomodo
force-pushed
the
troy/future-ext
branch
from
fb1b83a to
0b84416
Compare
|
?brawl merge |
|
📌 Commit 0b84416 has been approved and added to the merge queue. Requested by: @TroyKomodo Approved by: @lennartkloock |
|
🎉 Build successful! Approved by: @lennartkloock |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 48.91% 49.75% +0.84%
==========================================
Files 199 201 +2
Lines 16329 16436 +107
==========================================
+ Hits 7987 8178 +191
+ Misses 8342 8258 -84
... and 6 files with indirect coverage changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the syntax for
tokio::time::timeoutto be quite ugly, since it breaks the typical chained method calls. With the FutureExt trait we can just call.with_timeout(..)instead which seems to be a cleaner way to do it.