fix doc coverage bug #235
Merged
fix doc coverage bug #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason cargo llvm-cov report does not include doc coverage even if the doc coverage profraw files are there. It seems you also need to add the flag `--doctests` to the report command. I opened an upstream issue to see if this is the desired behaviour or not. It seems a bit unintuitive. taiki-e/cargo-llvm-cov#412
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 48.91% 49.75% +0.83%
==========================================
Files 199 200 +1
Lines 16329 16424 +95
==========================================
+ Hits 7987 8171 +184
+ Misses 8342 8253 -89 see 6 files with indirect coverage changes
|
lennartkloock
approved these changes
Jan 5, 2025
|
?brawl merge |
|
📌 Commit 42590b4 has been approved and added to the merge queue. Requested by: @lennartkloock Approved by: @lennartkloock |
|
🎉 Build successful! Approved by: @lennartkloock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason cargo llvm-cov report does not include doc coverage even if the doc coverage profraw files are there. It seems you also need to
add the flag
--docteststo the report command.I opened an upstream issue to see if this is the desired behaviour or not. It seems a bit unintuitive.
taiki-e/cargo-llvm-cov#412