Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scuffle-signal: test coverage and docs #236

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

lennartkloock
Copy link
Member

  • Improve test coverage
  • Improve docs by adding examples

@lennartkloock lennartkloock marked this pull request as draft January 6, 2025 14:00
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.35%. Comparing base (a958b8b) to head (611354b).
Report is 9 commits behind head on main.

Current head 611354b differs from pull request most recent head c44f941

Please upload reports for the commit c44f941 to get more accurate results.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   49.99%   50.35%   +0.35%     
==========================================
  Files         201      201              
  Lines       16343    16314      -29     
==========================================
+ Hits         8171     8215      +44     
+ Misses       8172     8099      -73     
Files with missing lines Coverage Δ
crates/context/src/lib.rs 100.00% <ø> (ø)
crates/signal/src/bootstrap.rs 100.00% <ø> (+100.00%) ⬆️
crates/signal/src/lib.rs 100.00% <ø> (+32.46%) ⬆️
Components Coverage Δ
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 27.15% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <ø> (ø)
scuffle-metrics 42.69% <ø> (ø)
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 100.00% <ø> (+58.39%) ⬆️
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

crates/signal/README.md Outdated Show resolved Hide resolved
@lennartkloock lennartkloock marked this pull request as ready for review January 7, 2025 00:27
@lennartkloock lennartkloock changed the title fix(signal): more tests and docs scuffle-signal: test coverage and docs Jan 7, 2025
@lennartkloock
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 7, 2025

📌 Commit c44f941 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @TroyKomodo

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 7, 2025

⌛ Trying commit c44f941 with merge 6d886bf...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 7, 2025

🎉 Build successful!
Completed in 7:48

Approved by: @TroyKomodo
Pushing 6d886bf to main

@scuffle-brawl scuffle-brawl bot merged commit 6d886bf into main Jan 7, 2025
7 checks passed
@scuffle-brawl scuffle-brawl bot deleted the lennart/ALL-8-scuffle-signal branch January 7, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants