Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert nightly to older build #242

Merged
merged 2 commits into from
Jan 9, 2025
Merged

revert nightly to older build #242

merged 2 commits into from
Jan 9, 2025

Conversation

TroyKomodo
Copy link
Member

the latest nightly broke on coverage checking so we pin it back to continue working. We will unpin it after nightly has been fixed.

@TroyKomodo
revert nightly to older build
885c732 
the latest nightly broke on coverage checking so we pin it back to
continue working. We will unpin it after nightly has been fixed.
@TroyKomodo
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

📌 Commit 064744c has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by:

scuffle-brawl bot added a commit that referenced this pull request Jan 9, 2025
@scuffle-brawl
Auto merge of #242 - troy/pin-nightly, r=TroyKomodo
53cf19c 
revert nightly to older build
the latest nightly broke on coverage checking so we pin it back to continue working. We will unpin it after nightly has been fixed.

Requested-by: TroyKomodo <[email protected]>
@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

⌛ Trying commit 064744c with merge 53cf19c...

@TroyKomodo
Copy link
Member Author

?brawl cancel

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

🚨 Cancelled CI run

@TroyKomodo
Copy link
Member Author

Why arent you apart of the approvers :|

@TroyKomodo
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

📌 Commit 064744c has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by:

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

⌛ Trying commit 064744c with merge 0f0631c...

scuffle-brawl bot added a commit that referenced this pull request Jan 9, 2025
@scuffle-brawl
Auto merge of #242 - troy/pin-nightly, r=TroyKomodo
0f0631c 
revert nightly to older build
the latest nightly broke on coverage checking so we pin it back to continue working. We will unpin it after nightly has been fixed.

Requested-by: TroyKomodo <[email protected]>
@TroyKomodo
Copy link
Member Author

?brawl cancel

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

🚨 Cancelled CI run

TroyKomodo added a commit to ScuffleCloud/brawl that referenced this pull request Jan 9, 2025
@TroyKomodo
fix(bug): related to review comments hiding approved reviews
5fcf80c 
GitHub returns reviewed comments as a review status, so we need to
filter those out to check if the reviewer has approved the PR or not.

fixes bug seen on ScuffleCloud/scuffle#242
@TroyKomodo
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

📌 Commit 064744c has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @lennartkloock

@lennartkloock
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

⌛ Trying commit 064744c with merge dc12b9a...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

🚨 Cannot add PR to merge queue while another run is pending, use ?brawl cancel to cancel it first & then try again.

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 9, 2025

🎉 Build successful!
Completed in 8:16

Approved by: @lennartkloock
Pushing dc12b9a to main

@scuffle-brawl scuffle-brawl bot merged commit dc12b9a into main Jan 9, 2025
7 checks passed
@scuffle-brawl scuffle-brawl bot deleted the troy/pin-nightly branch January 9, 2025 21:10
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.43%. Comparing base (87971c7) to head (99fe4ba).
Report is 3 commits behind head on main.

❗ Current head 99fe4ba differs from pull request most recent head 064744c

Please upload reports for the commit 064744c to get more accurate results.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files         198      198           
  Lines       16269    16269           
=======================================
  Hits         8206     8206           
  Misses       8063     8063
Components Coverage Δ
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 27.15% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <ø> (ø)
scuffle-metrics 42.69% <ø> (ø)
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 100.00% <ø> (ø)
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

@TroyKomodo TroyKomodo mentioned this pull request Jan 10, 2025
Merged
scuffle-brawl bot added a commit that referenced this pull request Jan 10, 2025
@scuffle-brawl
Auto merge of #243 - troy/unpin-nightly, r=lennartkloock
97d85c1 
unpin nightly
unpin the nightly pin introduced by #242 since nightly has now been fixed

Requested-by: lennartkloock <[email protected]>
Reviewed-by: lennartkloock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennartkloock lennartkloock lennartkloock approved these changes

Assignees
No one assigned
Labels
B-brawl-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TroyKomodo @lennartkloock