Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a readme and licenese for the aac crate #244

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

TroyKomodo
Copy link
Member

setup the create to be ready to publish

setup the create to be ready to publish
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.43%. Comparing base (dc12b9a) to head (e881752).
Report is 14 commits behind head on main.

Current head e881752 differs from pull request most recent head 0737aa6

Please upload reports for the commit 0737aa6 to get more accurate results.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files         198      198           
  Lines       16269    16269           
=======================================
  Hits         8206     8206           
  Misses       8063     8063           
Files with missing lines Coverage Δ
crates/aac/src/lib.rs 89.65% <ø> (ø)
Components Coverage Δ
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 27.15% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <ø> (ø)
scuffle-metrics 42.69% <ø> (ø)
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 100.00% <ø> (ø)
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

@lennartkloock
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

📌 Commit 0737aa6 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @lennartkloock

scuffle-brawl bot added a commit that referenced this pull request Jan 10, 2025
adds a readme and licenese for the aac crate
setup the create to be ready to publish

Requested-by: lennartkloock <[email protected]>
Reviewed-by: lennartkloock <[email protected]>
@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

⌛ Trying commit 0737aa6 with merge c5e11eb...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

🚨 PR has changed while a merge was in progress, cancelling the merge job.

@TroyKomodo
Copy link
Member Author

?brawl retry

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

📌 Commit 0737aa6 has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @lennartkloock

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

⌛ Trying commit 0737aa6 with merge f45f7b0...

scuffle-brawl bot added a commit that referenced this pull request Jan 10, 2025
adds a readme and licenese for the aac crate
setup the create to be ready to publish

Requested-by: TroyKomodo <[email protected]>
Reviewed-by: lennartkloock <[email protected]>
@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

🚨 PR has changed while a merge was in progress, cancelling the merge job.

@TroyKomodo
Copy link
Member Author

?brawl retry

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

📌 Commit 0737aa6 has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @lennartkloock

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

⌛ Trying commit 0737aa6 with merge 905efab...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 10, 2025

🎉 Build successful!
Completed in 8:52

Approved by: @lennartkloock
Pushing 905efab to main

@scuffle-brawl scuffle-brawl bot merged commit 905efab into main Jan 10, 2025
7 checks passed
@scuffle-brawl scuffle-brawl bot deleted the troy/aac-docs branch January 10, 2025 17:51
TroyKomodo added a commit to ScuffleCloud/brawl that referenced this pull request Jan 10, 2025
After a change in BASE github puts a PR in an `unknown`, we shouldnt
cancel the run if its in this state.

ScuffleCloud/scuffle#244 (comment)

Is where it was observed when merging multiple PRs concurrently.
TroyKomodo added a commit to ScuffleCloud/brawl that referenced this pull request Jan 10, 2025
After a change in BASE github puts a PR in an `unknown` mergeable state, we shouldn't cancel the run if its in this state.

ScuffleCloud/scuffle#244 (comment)

Is where it was observed when merging multiple PRs concurrently.
TroyKomodo added a commit to ScuffleCloud/brawl that referenced this pull request Jan 10, 2025
After a change in BASE github puts a PR in an `unknown` mergeable state
we shouldn't cancel the run if its in this state.

ScuffleCloud/scuffle#244 (comment)

Is where it was observed when merging multiple PRs concurrently.
scuffle-brawl bot added a commit to ScuffleCloud/brawl that referenced this pull request Jan 10, 2025
fix: pr temporarily going into unknown status canceling runs
After a change in BASE github puts a PR in an `unknown` mergeable state, we shouldn't cancel the run if its in this state.

ScuffleCloud/scuffle#244 (comment)

Is where it was observed when merging multiple PRs concurrently.

Requested-by: lennartkloock <[email protected]>
Reviewed-by: lennartkloock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants