cleanup amf0 crate

[TroyKomodo]

Cleans up the AMF0 decoder / encoder crate and adds some documentation around its usage.

CLOUD-24

[codecov]

Codecov Report

Attention: Patch coverage is 98.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.21%. Comparing base (ff39b23) to head (c5264fc).
Report is 7 commits behind head on main.

❗ Current head c5264fc differs from pull request most recent head f1e9b86

Please upload reports for the commit f1e9b86 to get more accurate results.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/amf0/src/encode.rs	91.83%	4 Missing ⚠️
crates/amf0/src/decode.rs	98.96%	1 Missing ⚠️
crates/flv/src/errors.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   49.70%   49.21%   -0.50%     
==========================================
  Files         196      194       -2     
  Lines       16033    15876     -157     
==========================================
- Hits         7970     7813     -157     
  Misses       8063     8063              

Files with missing lines	Coverage Δ
crates/amf0/src/define.rs	100.00% <100.00%> (ø)
crates/flv/src/define.rs	62.50% <ø> (ø)
crates/flv/src/flv.rs	81.28% <100.00%> (+0.11%)	⬆️
crates/rtmp/src/messages/define.rs	100.00% <ø> (ø)
crates/rtmp/src/messages/errors.rs	100.00% <ø> (ø)
crates/rtmp/src/messages/parser.rs	100.00% <100.00%> (ø)
crates/rtmp/src/messages/tests.rs	93.82% <100.00%> (-0.30%)	⬇️
crates/rtmp/src/netconnection/errors.rs	100.00% <ø> (ø)
crates/rtmp/src/netconnection/tests.rs	100.00% <100.00%> (ø)
crates/rtmp/src/netconnection/writer.rs	100.00% <100.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

Components	Coverage Δ
scuffle-batching	100.00% <ø> (ø)
scuffle-bootstrap	27.15% <ø> (ø)
scuffle-context	100.00% <ø> (ø)
scuffle-ffmpeg	0.00% <ø> (ø)
scuffle-h3-webtransport	0.00% <ø> (ø)
scuffle-http	0.00% <ø> (ø)
scuffle-metrics	42.69% <ø> (ø)
scuffle-pprof	0.00% <ø> (ø)
scuffle-settings	0.00% <ø> (ø)
scuffle-signal	100.00% <ø> (ø)
postcompile	0.00% <ø> (ø)
scuffle-image-processor	∅ <ø> (∅)

[lennartkloock]

Another thing I noticed: Don't we have to support amf0 references?

[TroyKomodo]

amf0 references

I have never seen an example of video data which produces them, which is why I didnt implement them. They are also a bit tricky to implement given the structure is stateless. Never mind, i read the spec incorrectly, they are specifically for arrays. We dont even support strict arrays. I think if we need this we will add it later.

[lennartkloock]

?brawl merge

[scuffle-brawl]

📌 Commit b8b63c8 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @lennartkloock

[scuffle-brawl]

🔒 Merge conflict
This pull request and the main branch have diverged in a way
that cannot be automatically merged. Please rebase your branch ontop of the
latest main branch and let the reviewer approve again.

Attempted merge from b8b63c8 into ff39b23

How do I rebase?

1. git checkout troy/amf0 (Switch to your branch)
2. git fetch upstream main (Fetch the latest changes from the
   upstream)
3. git rebase upstream/main -p (Rebase your branch onto the
   upstream branch)
4. Follow the prompts to resolve any conflicts (use git status if you get
   lost).
5. git push self troy/amf0 --force-with-lease (Update this PR)`

You may also read
Git Rebasing to Resolve Conflicts by Drew Blessing
for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub.
It uses git merge instead of git rebase which makes the PR commit
history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually
due to difference between how Cargo.lock conflict is handled during merge
and rebase. This is normal, and you should still perform step 5 to update
this PR.

[TroyKomodo]

?brawl merge

[scuffle-brawl]

📌 Commit f1e9b86 has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @lennartkloock

[scuffle-brawl]

⌛ Trying commit f1e9b86 with merge 38b399b...

[scuffle-brawl]

🎉 Build successful!
Completed in 9:03

• brawl-done

Approved by: @lennartkloock
Pushing 38b399b to main