fix: use after free in ffmpeg

[Juliapixel]

Motivation

there is a use after free in encoder::Encoder::new when codec-specific options are used

Solution

don't use after free

[TroyKomodo]

?brawl merge

[scuffle-brawl]

📌 Commit 51b98d1 has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by:

[TroyKomodo]

?brawl cancel

[scuffle-brawl]

🚨 Cancelled CI run

[TroyKomodo]

?brawl merge

[scuffle-brawl]

📌 Commit 51b98d1 has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @TroyKomodo

[scuffle-brawl]

⌛ Trying commit 51b98d1 with merge 382cbb0...

[scuffle-brawl]

🎉 Build successful!
Completed in 2:22

• brawl-done

Approved by: @TroyKomodo
Pushing 382cbb0 to main

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 50.24%. Comparing base (905efab) to head (4126e27).
Report is 3 commits behind head on main.

❗ Current head 4126e27 differs from pull request most recent head 51b98d1

Please upload reports for the commit 51b98d1 to get more accurate results.

Files with missing lines	Patch %	Lines
crates/ffmpeg/src/encoder.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   50.24%   50.24%   -0.01%     
==========================================
  Files         196      196              
  Lines       16202    16204       +2     
==========================================
  Hits         8141     8141              
- Misses       8061     8063       +2     

Files with missing lines	Coverage Δ
crates/ffmpeg/src/encoder.rs	0.00% <0.00%> (ø)

Components	Coverage Δ
scuffle-batching	100.00% <ø> (ø)
scuffle-bootstrap	27.15% <ø> (ø)
scuffle-context	100.00% <ø> (ø)
scuffle-ffmpeg	0.00% <0.00%> (ø)
scuffle-h3-webtransport	0.00% <ø> (ø)
scuffle-http	0.00% <ø> (ø)
scuffle-metrics	42.69% <ø> (ø)
scuffle-pprof	0.00% <ø> (ø)
scuffle-settings	0.00% <ø> (ø)
scuffle-signal	100.00% <ø> (ø)
postcompile	0.00% <ø> (ø)
scuffle-image-processor	∅ <ø> (∅)