Add monochrome icon variant for android 13 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On my Pixel 6 Pro (emulator, API 33) it looks like this: |
|
Ah, I see that you added an inset for the non-monochrome version in the app icon xml - I've added that to the monochrome icon as well. Didn't catch that on my phone as the theme seems to provide its own inset for all icons. I've also slightly bumped the inset on the regular icon so it displays better on round icons. |
|
Looks good to me now! |
udenr
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I recently upgraded to android 13 and noticed that your app does not yet support monochrome app icons for theming. This makes the app stand out quite a bit when placed next to other apps that do support theming, so I added a simple monochrome version of the app icon.
[privacy]
Here's a before and after showing the themed and un-themed icon next to some other themed apps:
