Update to version 1.2.0 #122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
udenr
commented
Dec 9, 2024
udenr
commented
- Add dark mode
- Update to target api 34
- Update dependencies
- Add ci workflow
- Switch to `DayNight` theme in `styles.xml` - Add `values-night/styles.xml` to define dark theme colors - Replace usage of `android.app.AlertDialog` with `androidx.appcompat.app.AlertDialog` to respect theme - Fix colors for selected/unselected items in ProductsItemViewHolder as they were difficult to see depending on the theme - Add listener for theme change to `SettingsActivity.java` to apply changes directly - Fix text color in `main_toolbar.xml` - Remove unnecessary `FragmentContainerView` from `activity_settings.xml` - Add theme to BackupRestorer.kt
…nd ProductsItemViewHolder.java
Add workflows and fix lint errors
…lect-darklight-mode Add support for dark/light theme
- Upgrade backup api to v1.4.0 - Change target sdk to 34 - Upgrade gradle and kotlin version - Update other dependencies
- Fix version mismatch between Java target and Kotlin target - Add missing permission
Update dependencies
|
@jahway603 can try out this version. If there are any visual problems in either light or dark mode, please let me know. I checked most of the views but might have missed some where the style is not correctly applied and you get, e.g., black text on a black background. It doesn't need to be perfect for now but shouldn't be worse than the previous version. Once you've tested it, I'll then create a release to publish it on Google Play / F-Droid. I attached a signed APK, so that you don't have to build the version yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.