Skip to content

Commit

Permalink
refactor: taskfile var changes (#140)
Browse files Browse the repository at this point in the history
  • Loading branch information
JonZeolla authored Aug 4, 2023
1 parent e31b77b commit c0ddbe3
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 20 deletions.
3 changes: 0 additions & 3 deletions .github/etc/dictionary.txt
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
buildx
ggpull
updategoat
1 change: 0 additions & 1 deletion Task/bash/Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ tasks:
INPUT_DISABLE_MYPY: '{{.INPUT_DISABLE_MYPY | default ""}}'
INPUT_EXCLUDE: '{{.INPUT_EXCLUDE | default ""}}'
INPUT_LOG_LEVEL: '{{.INPUT_LOG_LEVEL | default ""}}'
IMAGE_NAME: '{{.IMAGE_NAME | default ""}}'

build:
desc: Build the project; docker images, compiled binaries, etc.
Expand Down
14 changes: 4 additions & 10 deletions Task/python/Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ includes:
taskfile: ../Taskfile.yml
internal: true

vars:
VERSION:
sh: pipenv run python -c 'from {{.PROJECT_SLUG}} import __version__; print(__version__)'

tasks:
lint:
desc: Run the linter(s); paved road projects use the Seiso goat 🐐
Expand All @@ -38,12 +34,11 @@ tasks:
build:
desc: Build the project; docker images, compiled binaries, etc.
platforms: [linux, darwin]
requires:
vars: ['VERSION']
cmds:
- task: base:build
vars:
VERSION: '{{.VERSION}}'
# Unable to make this global due to https://taskfile.dev/usage/#variables see https://github.com/go-task/task/issues/1295
VERSION: pipenv run python -c 'from {{.PROJECT_SLUG}} import __version__; print(__version__)'
PLATFORM: '{{.PLATFORM | default ""}}'
DOCKER_BUILDX_CUSTOM_ARGS: '{{.DOCKER_BUILDX_CUSTOM_ARGS | default ""}}'

Expand All @@ -61,13 +56,12 @@ tasks:
publish:
desc: Publish the project artifacts; docker images, compiled binaries, etc.
platforms: [linux, darwin]
requires:
vars: ['VERSION']
cmds:
- task: base:pipeline-docker-multiplatform-init
- task: base:publish
vars:
VERSION: '{{.VERSION}}'
# Unable to make this global due to https://taskfile.dev/usage/#variables see https://github.com/go-task/task/issues/1295
VERSION: pipenv run python -c 'from {{.PROJECT_SLUG}} import __version__; print(__version__)'
PLATFORM: '{{.PLATFORM | default ""}}'
DOCKER_BUILDX_CUSTOM_ARGS: '{{.DOCKER_BUILDX_CUSTOM_ARGS | default ""}}'

Expand Down
7 changes: 4 additions & 3 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ includes:
internal: true
optional: true
vars:
IMAGE_NAME: "{{.IMAGE_NAME}}"
PROJECT_SLUG: "{{.PROJECT_SLUG}}"
PYTHON_VERSION: "{{.PYTHON_VERSION}}"
IMAGE_NAME: seiso/goat
PROJECT_SLUG: goat
PYTHON_VERSION: 3.11

vars:
# This unfortunately needs to be duplicated, pending https://github.com/go-task/task/issues/1295
IMAGE_NAME: seiso/goat
PROJECT_SLUG: goat
PYTHON_VERSION: 3.11
Expand Down
7 changes: 5 additions & 2 deletions etc/seiso_global_dictionary.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ bruteforce
bruteforcing
bssid
bssids
buildx
capricornis
casp
cissp
Expand Down Expand Up @@ -51,6 +52,7 @@ flameshot
gcux
gcwn
getuserspns
ggpull
giac
gitleaks
gitpython
Expand Down Expand Up @@ -135,9 +137,9 @@ sast
secretsdump
seiso
seiso's
seiso’s
seisollc
seisosimpleshell
seiso’s
servdev
sha256
sha256sum
Expand Down Expand Up @@ -165,6 +167,7 @@ typosquat
typosquatting
unmarshal
unmarshalling
updategoat
vectr
vimrc
vishing
Expand All @@ -181,4 +184,4 @@ wrike
wrike's
xml
xss
xxe
xxe
2 changes: 1 addition & 1 deletion goat
Submodule goat updated 5 files
+1 −1 .pre-commit-config.yaml
+1 −1 VERSION
+1 −1 action.yml
+1 −1 goat
+1 −1 setup.cfg

0 comments on commit c0ddbe3

Please sign in to comment.