Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed macos from github workflows #1796

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Removed macos from github workflows #1796

wants to merge 1 commit into from

Conversation

RobertSamoilescu
Copy link
Contributor

@RobertSamoilescu RobertSamoilescu commented Jun 7, 2024 •
edited
Loading

This PR removes macos from the github worflow.

torch >= 2.2.0 not longer supported for macos. See issue here

sakoush
sakoush approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Add notes in the description why we are not doing the macos tests anymore.
Also check in the docs if there is a reference that says we support macos, if so then adjust accordingly.

@RobertSamoilescu RobertSamoilescu marked this pull request as draft June 7, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakoush sakoush sakoush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertSamoilescu @sakoush