-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Deprecate CDP methods on Firefox #14787
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
This reverts commit 49148e6.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit ef0d787)
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
1b2bb39
to
43c569b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14787 +/- ##
==========================================
- Coverage 59.24% 59.21% -0.04%
==========================================
Files 94 94
Lines 6004 6009 +5
Branches 268 268
==========================================
+ Hits 3557 3558 +1
- Misses 2179 2183 +4
Partials 268 268 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
43c569b
to
657f5d3
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
657f5d3
to
ef0d787
Compare
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This pull request introduces deprecation warnings for CDP (Chrome DevTools Protocol) support in Firefox and updates the corresponding tests. The most important changes include adding a deprecation warning in the
webdriver
module and ensuring that the tests handle these warnings appropriately.Deprecation warning for CDP support in Firefox:
py/selenium/webdriver/remote/webdriver.py
: Added a deprecation warning for CDP support in Firefox, advising users to switch to WebDriver BiDi.Updates to tests to handle deprecation warnings:
py/test/selenium/webdriver/common/devtools_tests.py
: Modified thetest_check_console_messages
test to check for the deprecation warning when using Firefox.py/test/selenium/webdriver/firefox/firefox_service_tests.py
: Updated thetest_log_output_as_filename
test to ensure no warnings are recorded.py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py
: Added a check to ensure no warnings are recorded when initializing theRemote
driver with Firefox options.Motivation and Context
Types of changes
Checklist
PR Type
enhancement, tests
Description
Changes walkthrough 📝
webdriver.py
Add deprecation warning for CDP in Firefox
py/selenium/webdriver/remote/webdriver.py
devtools_tests.py
Update tests to handle Firefox CDP deprecation
py/test/selenium/webdriver/common/devtools_tests.py
firefox_service_tests.py
Ensure no warnings in Firefox service tests
py/test/selenium/webdriver/firefox/firefox_service_tests.py
remote_firefox_profile_tests.py
Ensure no warnings in remote Firefox profile tests
py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py