Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: student favourited courses list #85

Open
wants to merge 3 commits into
base: mw_lc_74_favourite_courses
Choose a base branch
from

Conversation

wielopolski
Copy link
Collaborator

Jira issue(s)

https://selleolabs.atlassian.net/jira/software/projects/LC/boards/3?selectedIssue=LC-76

Overview

This PR add endpoint with list of favourited courses for student.

Screenshots

image

@wielopolski wielopolski added the review me 👀 PR is ready to be reviewed label Sep 12, 2024
@wielopolski wielopolski self-assigned this Sep 12, 2024
@wielopolski wielopolski force-pushed the mw_lc_74_favourite_courses branch 2 times, most recently from 658f3ef to 2c4c77f Compare September 12, 2024 12:24
@wielopolski wielopolski force-pushed the mw_lc_75_student_favourited_courses_list branch from 555296a to 46d8ea4 Compare September 12, 2024 12:38
@wielopolski wielopolski force-pushed the mw_lc_75_student_favourited_courses_list branch from 46d8ea4 to bcdb1fe Compare September 12, 2024 12:42
@wielopolski wielopolski marked this pull request as ready for review September 12, 2024 12:44
@wielopolski wielopolski added Status: WIP 🏗 Work in progress blocked 🛑 PR currently is blocked by other issue, external party etc. and removed review me 👀 PR is ready to be reviewed Status: WIP 🏗 Work in progress labels Sep 20, 2024
@PoslinskiNet
Copy link
Member

@wielopolski what it is blocked? Leave a comment in such cases for future you and other contributors with some context information.

@wielopolski
Copy link
Collaborator Author

At the time the PR was created, feature was ready to be introduced. It was blocked due to the preparation of the application according to other criteria which blocked its implementation

@PoslinskiNet
Copy link
Member

@wielopolski so, what should happen to unblock this PR?

@wielopolski
Copy link
Collaborator Author

@PoslinskiNet in the current situation, I would close both PRs and create a new approach based on them:

  • I would extend studentCourses with an isFavourite field
  • in course.controller.ts, I would extend response in student queries with a new field
  • use the endpoints prepared in the PR to add and remove the isFavourite flag

@PoslinskiNet
Copy link
Member

Could you handoff this to @MarcinMaciejewski337 so we will utilize the knowledge already gained with those and add some new functionality to the core? What do you think @wielopolski?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked 🛑 PR currently is blocked by other issue, external party etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants