F1: fixing usb issues from #64 #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
not done; need to address size issue
Certain Blue Pills with fake STM32 chips had issues properly completing USB negotiations. Plugging them in resulted in a Device Descriptor Request failed error.
This issue occurred even in the initial release and was fixed by making the same change made in bootsector/stm32-hid-bootloader e58113c; this fix only worked on older versions, however, thus another bug was known to be present. This was traced to 79c474e and was addressed by effectively reverting this commit.
Doing so created another problem which is that the bootloader was now larger than 2KB. -> am working on figuring out some way to address this