Role-ban check for antag roles (#2050)

SerbiaStrong-220 · Oct 11, 2024 · 4783886 · 4783886
1 parent f1b2814
commit 4783886
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs b/Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs
@@ -664,7 +664,14 @@ public void RefreshAntags()
                 selector.Select(Profile?.AntagPreferences.Contains(antag.ID) == true ? 0 : 1);
 
                 var requirements = _entManager.System<SharedRoleSystem>().GetAntagRequirement(antag);
-                if (!_requirements.CheckRoleRequirements(requirements, (HumanoidCharacterProfile?)_preferencesManager.Preferences?.SelectedCharacter, out var reason))
+                // SS220 Add role-ban check begin
+                if (_requirements.IsRoleBaned(antag.ID, out var banReason))
+                {
+                    selector.LockRequirements(banReason);
+                    Profile = Profile?.WithAntagPreference(antag.ID, false);
+                    SetDirty();
+                } // SS220 Add role-ban check end
+                else if (!_requirements.CheckRoleRequirements(requirements, (HumanoidCharacterProfile?)_preferencesManager.Preferences?.SelectedCharacter, out var reason)) // SS220 change 'if' -> 'else if'
                 {
                     selector.LockRequirements(reason);
                     Profile = Profile?.WithAntagPreference(antag.ID, false);

diff --git a/Content.Client/Players/PlayTimeTracking/JobRequirementsManager.cs b/Content.Client/Players/PlayTimeTracking/JobRequirementsManager.cs
@@ -190,4 +190,18 @@ public IReadOnlyDictionary<string, TimeSpan> GetPlayTimes(ICommonSession session
 
         return _roles;
     }
+
+    // SS220 Add role-ban check begin
+    public bool IsRoleBaned(string role, [NotNullWhen(true)] out FormattedMessage? reason)
+    {
+        if (_roleBans.Contains($"Job:{role}"))
+        {
+            reason = FormattedMessage.FromUnformatted(Loc.GetString("role-ban"));
+            return true;
+        }
+
+        reason = null;
+        return false;
+    }
+    // SS220 Add role-ban check end
 }