Add required file sources (closes #110) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorio
force-pushed
the
feature/required-files
branch
2 times, most recently
from
728f06c
to
7780c6c
Compare
Setting `.required(true)` on a `Data` provider with a file path source will make the provider fail when the file does not exist. This contrasts with the default behaviour of `.required(false)` which treats missing files as empty dictionaries. Resolves SergioBenitez#110.
This commit extends the previous commit by also making source file searching dynamically configurable as opposed to forcing the choice when the data source is created. The `file_exact()` constructor is deprecated in favor of `file().search(false)`.
SergioBenitez
force-pushed
the
feature/required-files
branch
from
7780c6c
to
4acf45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #110.