feat: preserve_order feature #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10
to
+15
| #[cfg(not(feature = "preserve_order"))] | ||
| pub type Map<K, V> = BTreeMap<K, V>; | ||
|
|
||
| /// An alias to the type of map used in [`Value::Dict`]. | ||
| #[cfg(feature = "preserve_order")] | ||
| pub type Map<K, V> = indexmap::IndexMap<K, V>; |
There was a problem hiding this comment.
We cannot do this: features must be additive. This breaks that.
|
I'm okay with the idea in general, but this implementation is incorrect. If we're going to do this, the cost is making the map type opaque as otherwise we cannot switch the implementation via a feature. See how As you can see, this is rather unfortunate - there's a lot of duplication. The alternative is to always use |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
preserve_orderfeature to preserve the map order.I haven't add corresponding test to this library since compilation errors (for all tests) occurs when I run
cargo testand I don't know the correct command to run those tests. However, I do have a test in my external test environment, and it works fine.This feature solves #89