Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesheets per user record fetcher #127

Merged
merged 18 commits into from
Oct 30, 2017
Merged

Conversation

skatkov
Copy link

@skatkov skatkov commented Oct 21, 2017

Tsheet::API gem has failed me and I got no support from tsheets maintainers. A bit more details here:

TSheetsTeam/api_ruby#5

I don't want to fix their gem, I consider it a peace of garbage. So here is a rough wrapper I started writing to achieve desired results.

screen shot 2017-10-28 at 04 36 56

  • Timesheet tab is only shown for users with tsheets_id
  • Minimal timesheets fetcher, currently it only records event.

Timesheets data is currently not shown, but it's a huge Pull Request already -- it would be a great baseline to improve on.

@skatkov skatkov changed the title Tsheet user fetcher Timesheets user fetcher Oct 21, 2017
@Dangerbot1
Copy link
Collaborator

Dangerbot1 commented Oct 25, 2017

1 Warning
⚠️ Big PR – consider splitting it up.

Generated by 🚫 Danger

@skatkov skatkov force-pushed the work_order_tsheets branch from ddabb12 to 5e5b0aa Compare October 27, 2017 20:45
@skatkov skatkov force-pushed the work_order_tsheets branch from d50e44c to 0d4c828 Compare October 27, 2017 21:46
@skatkov skatkov changed the title Timesheets user fetcher Timesheets per user record fetcher Oct 28, 2017
\"\",\n \"required_customfields\": [\n \n ]\n }\n }\n }\n}"
http_version:
recorded_at: Wed, 25 Oct 2017 18:57:04 GMT
recorded_with: VCR 3.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I see what you mean this recording right here is a load

@bradbergeron-us bradbergeron-us merged commit b65c1d6 into master Oct 30, 2017
@skatkov skatkov deleted the work_order_tsheets branch October 30, 2017 09:05
Copy link
Contributor

@bradbergeron-us bradbergeron-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So When clicking the refresh data, I can't see anything that's coming over. What is the next step to get that working?

@skatkov
Copy link
Author

skatkov commented Oct 30, 2017

@bradbergeron-us yeah, this is my next pull request. You'll have that working today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants