Data mappers refactoring #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
data-mapper-refactoring
branch
from
ff8807c to
4d3fc55
Compare
loevgaard
reviewed
Sep 13, 2024
src/DataMapper/Product/Provider/ReflectionAttributeValuesProvider.php
Outdated
Show resolved
Hide resolved
Zales0123
force-pushed
the
data-mapper-refactoring
branch
from
0a1a8b2 to
7d2d327
Compare
Zales0123
force-pushed
the
data-mapper-refactoring
branch
from
7d2d327 to
34d46d1
Compare
|
@loevgaard according to our conversation, I've lowered the abstractness of some services, also moved attributed and options mapping to metadata. Should be better now 🖖 let me know if you have any more doubts |
loevgaard
reviewed
Sep 16, 2024
loevgaard
reviewed
Sep 16, 2024
loevgaard
reviewed
Sep 16, 2024
loevgaard
reviewed
Sep 16, 2024
loevgaard
reviewed
Sep 16, 2024
src/DataMapper/Product/Provider/AttributesDataMapperValuesProvider.php
Outdated
Show resolved
Hide resolved
loevgaard
reviewed
Sep 16, 2024
src/DataMapper/Product/Setter/DocumentAttributesValuesSetter.php
Outdated
Show resolved
Hide resolved
loevgaard
reviewed
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this refactoring, I've extracted a common logic from
AttributesDataMapperandOptionsDataMapper, covered it with more tests, and arranged it in services. Enjoy 🖖