Distribute discount over units #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
distribute-discount-over-units
branch
from
2003840 to
792d24a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
============================================
+ Coverage 70.44% 74.17% +3.73%
- Complexity 60 71 +11
============================================
Files 26 28 +2
Lines 318 364 +46
============================================
+ Hits 224 270 +46
Misses 94 94 ☔ View full report in Codecov by Sentry. |
loevgaard
reviewed
Jun 26, 2024
loevgaard
reviewed
Jun 26, 2024
loevgaard
reviewed
Jun 26, 2024
loevgaard
approved these changes
Jun 26, 2024
Zales0123
force-pushed
the
distribute-discount-over-units
branch
from
dd62656 to
06c23ae
Compare
loevgaard
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #14
I believe we should modify the
Order::getFullDiscountedUnitPricemethod, but I wanted to avoid adding the trait and changes in mapping for now so it's initially done on the template level. We can improve it later 🖖