Display order totals #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that's fine, however, we need the missing amounts also. In this case I guess it's the shipping that's missing. You might be wondering the reasoning. It's because when giving an order discount it's good for the customer service rep to see the actual amounts to be able to give the correct discounts. Let's say they have a customer complaining he didn't get free shipping. When the amount is right there, it's easy to give the correct discount |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 70.44% 70.44%
Complexity 60 60
=========================================
Files 26 26
Lines 318 318
=========================================
Hits 224 224
Misses 94 94 ☔ View full report in Codecov by Sentry. |
|
No problem, I will add missing total as well 👍 |
loevgaard
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Something like this? @loevgaard