Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output the error when failing to update the order #37

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

loevgaard
Copy link
Member

Fixes #36

@loevgaard loevgaard requested a review from Zales0123 August 16, 2024 09:17
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (fbd91c8) to head (6ab1891).
Report is 3 commits behind head on master.

Files Patch % Lines
src/Controller/EditOrderAction.php 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
- Coverage     73.71%   73.51%   -0.20%     
  Complexity       72       72              
============================================
  Files            28       28              
  Lines           369      370       +1     
============================================
  Hits            272      272              
- Misses           97       98       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard merged commit e52f4b0 into master Aug 16, 2024
31 of 32 checks passed
@loevgaard loevgaard deleted the output-error branch August 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Better error reporting to the user
1 participant