Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order update events #8

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Order update events #8

merged 6 commits into from
Jun 20, 2024

Conversation

Zales0123
Copy link
Collaborator

In this PR I added two events that can be thrown when the order is updated:

  • OrderUpated that is always thrown
  • PaidOrderTotalChanged that is thrown if the order was already paid - it can be useful to subscribe for for refund or gift cards functionality
  • another bunch of refactoring

@Zales0123 Zales0123 added the enhancement New feature or request label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.54%. Comparing base (62a38d4) to head (e4fbb72).

Files Patch % Lines
...ndencyInjection/SetonoSyliusOrderEditExtension.php 0.00% 7 Missing ⚠️
src/Entity/EditableOrderTrait.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
- Coverage     71.42%   70.54%   -0.89%     
- Complexity       52       58       +6     
============================================
  Files            23       26       +3     
  Lines           273      292      +19     
============================================
+ Hits            195      206      +11     
- Misses           78       86       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zales0123 Zales0123 force-pushed the order-edit-events branch from 93cd2b3 to 75334fc Compare June 18, 2024 13:56
@Zales0123 Zales0123 force-pushed the order-edit-events branch from 5e6a5f3 to a20a4b6 Compare June 19, 2024 09:00
@Zales0123 Zales0123 force-pushed the order-edit-events branch from a20a4b6 to 6e94683 Compare June 19, 2024 12:05
@Zales0123 Zales0123 force-pushed the order-edit-events branch from 6e94683 to e4fbb72 Compare June 19, 2024 12:05
@Zales0123 Zales0123 merged commit b6fd534 into master Jun 20, 2024
32 of 34 checks passed
@Zales0123 Zales0123 deleted the order-edit-events branch June 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants