Fixed the 'first wishlist redirect action' to only redirect if a wish…

…list exists

src/Controller/FirstWishlistRedirectAction.php

@@ -4,42 +4,50 @@
 
 namespace Setono\SyliusWishlistPlugin\Controller;
 
-use Doctrine\Persistence\ManagerRegistry;
-use Setono\Doctrine\ORMTrait;
-use Setono\SyliusWishlistPlugin\Factory\WishlistFactoryInterface;
 use Setono\SyliusWishlistPlugin\Provider\WishlistProviderInterface;
 use Symfony\Component\HttpFoundation\RedirectResponse;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Session\FlashBagAwareSessionInterface;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 
 /**
  * This class is used to redirect the user to the first wishlist.
  * This is useful if your application only needs one wishlist per user.
- *
- * NOTICE that it will persist the wishlist if it doesn't exist.
  */
 final class FirstWishlistRedirectAction
 {
-    use ORMTrait;
 
     public function __construct(
         private readonly WishlistProviderInterface $wishlistProvider,
-        private readonly WishlistFactoryInterface $wishlistFactory,
-        ManagerRegistry $managerRegistry,
         private readonly UrlGeneratorInterface $urlGenerator,
     ) {
-        $this->managerRegistry = $managerRegistry;
     }
 
-    public function __invoke(): RedirectResponse
+    public function __invoke(Request $request): RedirectResponse
     {
-        $wishlist = $this->wishlistProvider->getWishlists()[0];
+        $wishlists = $this->wishlistProvider->getWishlists();
+        if ([] === $wishlists) {
+            $session = $request->getSession();
+            if ($session instanceof FlashBagAwareSessionInterface) {
+                $session->getFlashBag()->add('info', 'setono_sylius_wishlist.no_wishlists');
+            }
 
-        $this->getManager($wishlist)->persist($wishlist);
-        $this->getManager($wishlist)->flush();
+            return $this->redirect($request);
+        }
 
         return new RedirectResponse($this->urlGenerator->generate(
             'setono_sylius_wishlist_shop_wishlist_show',
-            ['uuid' => $wishlist->getUuid()],
+            ['uuid' => $wishlists[0]->getUuid()],
         ));
     }
+
+    private function redirect(Request $request): RedirectResponse
+    {
+        $referrer = $request->headers->get('referer');
+        if (is_string($referrer) && '' !== $referrer) {
+            return new RedirectResponse($referrer);
+        }
+
+        return new RedirectResponse($this->urlGenerator->generate('sylius_shop_homepage'));
+    }
 }

src/Resources/config/services/controller.xml

@@ -25,8 +25,6 @@
 
         <service id="Setono\SyliusWishlistPlugin\Controller\FirstWishlistRedirectAction" public="true">
             <argument type="service" id="Setono\SyliusWishlistPlugin\Provider\WishlistProviderInterface"/>
-            <argument type="service" id="Setono\SyliusWishlistPlugin\Factory\WishlistFactoryInterface"/>
-            <argument type="service" id="doctrine"/>
             <argument type="service" id="router"/>
         </service>
 

src/Resources/translations/flashes.da.yaml

@@ -0,0 +1,2 @@
+setono_sylius_wishlist:
+    no_wishlists: Du har ikke tilføjet noget til din ønskeliste endnu

src/Resources/translations/flashes.en.yaml

@@ -0,0 +1,2 @@
+setono_sylius_wishlist:
+    no_wishlists: You haven't added anything to your wishlist yet

src/Resources/translations/flashes.no.yaml

@@ -0,0 +1,2 @@
+setono_sylius_wishlist:
+    no_wishlists: Du har ikke lagt til noe på ønskelisten din ennå