Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the renderer argument to be null #21

Merged
merged 1 commit into from
May 14, 2024
Merged

Allow the renderer argument to be null #21

merged 1 commit into from
May 14, 2024

Conversation

loevgaard
Copy link
Member

@loevgaard loevgaard commented May 14, 2024

If you just want to use the default renderers (i.e. element and content renderer), you don't have to provide an argument for the renderer anymore on the TagBag

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.93%. Comparing base (e3f5bc6) to head (a31b398).

Files Patch % Lines
src/Renderer/CompositeRenderer.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #21      +/-   ##
============================================
- Coverage     94.17%   93.93%   -0.24%     
- Complexity      137      139       +2     
============================================
  Files            24       24              
  Lines           326      330       +4     
============================================
+ Hits            307      310       +3     
- Misses           19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard merged commit 5a30419 into 2.x May 14, 2024
22 of 24 checks passed
@loevgaard loevgaard deleted the nullable-renderer branch May 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant