Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce serializer and introduce json serialization instead of php serialization #22

Merged
merged 1 commit into from
May 21, 2024

Conversation

loevgaard
Copy link
Member

No description provided.

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 80.72289% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 92.22%. Comparing base (5a30419) to head (9a166cf).

Files Patch % Lines
src/Serializer/PhpSerializer.php 70.37% 8 Missing ⚠️
src/Serializer/CompositeSerializer.php 76.47% 4 Missing ⚠️
src/Serializer/JsonSerializer.php 88.23% 2 Missing ⚠️
src/Tag/RenderedTag.php 89.47% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #22      +/-   ##
============================================
- Coverage     93.93%   92.22%   -1.72%     
- Complexity      139      163      +24     
============================================
  Files            24       27       +3     
  Lines           330      386      +56     
============================================
+ Hits            310      356      +46     
- Misses           20       30      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard force-pushed the serializer branch 2 times, most recently from e2a098e to 1526ad9 Compare May 21, 2024 09:13
@loevgaard loevgaard merged commit 25c2dc2 into 2.x May 21, 2024
22 of 24 checks passed
@loevgaard loevgaard deleted the serializer branch May 21, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant