Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass credentials to client #376

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat: pass credentials to client #376

merged 3 commits into from
Oct 3, 2024

Conversation

jorgenengelsen
Copy link
Contributor

@jorgenengelsen jorgenengelsen commented Oct 2, 2024 •
edited
Loading

Enables users to pass credentials into the SDK client. While preserving the env-variable option used previously

Option A) passing credentials:

client = Client(config(api_user="...", api_password="***"))

Option B) with env variables as before:

client = Client()

relates https://github.com/SevanSSP/inquire-modeltest-pipeline/issues/57

@jorgenengelsen jorgenengelsen self-assigned this Oct 2, 2024
@snorrefjellvang snorrefjellvang merged commit aab5ccf into master Oct 3, 2024
8 checks passed
@snorrefjellvang snorrefjellvang deleted the feat/pass-credentials branch October 3, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snorrefjellvang snorrefjellvang snorrefjellvang approved these changes

@EBGlom EBGlom Awaiting requested review from EBGlom

Assignees

@jorgenengelsen jorgenengelsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgenengelsen @snorrefjellvang