feat(Flydigi): Add support for flydigi vader 3/4 pro #308

Fabianoshz · 2025-03-05T10:28:06Z

This should add support for both flydigi vader 3 and 4.

Fixes #208

blindedone1458 · 2025-03-05T17:38:14Z

@Fabianoshz I think instead of doing all those remappings in the InputPlumber CapabilityMap, the xpad patch you are using should be updated so the Flydigi paddles match the Xbox Elite paddle mappings.
I've been using a Vader 3 Pro with xpad and this patch below based on cprn's patch here: paroj/xpad#268 (comment)

diff --git a/xpad.c b/xpad.c
index d5a016e..0e8f73f 100644
--- a/xpad.c
+++ b/xpad.c
@@ -95,6 +95,7 @@
 #define MAP_SELECT_BUTTON		(1 << 3)
 #define MAP_PADDLES			(1 << 4)
 #define MAP_PROFILE_BUTTON		(1 << 5)
+#define MAP_FLYDIGI_BUTTONS		(1 << 6)
 
 #define DANCEPAD_MAP_CONFIG	(MAP_DPAD_TO_BUTTONS |			\
 				MAP_TRIGGERS_TO_BUTTONS | MAP_STICKS_TO_NULL)
@@ -421,6 +422,19 @@ static const struct xpad_device {
 	{ 0x0000, 0x0000, "Generic X-Box pad", 0, XTYPE_UNKNOWN }
 };
 
+// A "flavor" is an aftermarket variant of an existing model supporting
+// additional features.
+static const struct xpad_flavor {
+	u16 idVendor;
+	u16 idProduct;
+	char *product;
+	u8 mapping;
+} xpad_flavor[] = {
+	{ 0x045e, 0x028e, "Flydigi VADER3", MAP_PADDLES | MAP_FLYDIGI_BUTTONS },
+	{ 0x045e, 0x028e, "Flydigi VADER4", MAP_PADDLES | MAP_FLYDIGI_BUTTONS },
+	{ 0x0000, 0x0000, NULL, 0 }
+};
+
 /* buttons shared with xbox and xbox360 */
 static const signed short xpad_common_btn[] = {
 	BTN_A, BTN_B, BTN_X, BTN_Y,			/* "analog" buttons */
@@ -484,6 +498,13 @@ static const struct {int x; int y; } dpad_mapping[] = {
 	{0, 0}
 };
 
+/* used for extra buttons in addition to paddles on Flydigi Vader Pro 3*/
+static const signed short xpad_btn_extra[] = {
+	BTN_TRIGGER_HAPPY9, BTN_TRIGGER_HAPPY10, /* Z, C face buttons */
+	BTN_TRIGGER_HAPPY11,			/* circle */
+	-1						/* terminating entry */
+};
+
 /*
  * Xbox 360 has a vendor-specific class, so we cannot match it with only
  * USB_INTERFACE_INFO (also specifically refused by USB subsystem), so we
@@ -940,6 +961,7 @@ static void xpad_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char *d
  *
  *	The used report descriptor was taken from:
  *		http://www.free60.org/wiki/Gamepad
+ *	Packet length for valid data is 20 bytes.
  */
 
 static void xpad360_process_packet(struct usb_xpad *xpad, struct input_dev *dev,
@@ -1012,6 +1034,17 @@ static void xpad360_process_packet(struct usb_xpad *xpad, struct input_dev *dev,
 		input_report_abs(dev, ABS_RZ, data[5]);
 	}
 
+	/* Additional buttons for Flydigi Vader Pro 3 presenting as 360 pad. */
+	if (xpad->mapping & MAP_FLYDIGI_BUTTONS) {
+		input_report_key(dev, BTN_TRIGGER_HAPPY10, data[19] & BIT(0));   // C
+		input_report_key(dev, BTN_TRIGGER_HAPPY9, data[19] & BIT(1));  // Z
+		input_report_key(dev, BTN_TRIGGER_HAPPY8, data[19] & BIT(3));   // Leftmost paddle (M2)
+		input_report_key(dev, BTN_TRIGGER_HAPPY7, data[19] & BIT(5));   // Second to leftmost (M4)
+		input_report_key(dev, BTN_TRIGGER_HAPPY5, data[19] & BIT(4));   // Second to rightmost (M3)
+		input_report_key(dev, BTN_TRIGGER_HAPPY6, data[19] & BIT(2));   // Rightmost paddle (M1)
+		input_report_key(dev, BTN_TRIGGER_HAPPY11, data[20] & BIT(0));  // Circle
+	}
+
 	input_sync(dev);
 
 	/* XBOX360W controllers can't be turned off without driver assistance */
@@ -2246,6 +2279,13 @@ static int xpad_init_input(struct usb_xpad *xpad)
 			input_set_capability(input_dev, EV_KEY, xpad_btn_paddles[i]);
 	}
 
+	/* set up extra face buttons if the controller has them */
+	if (xpad->mapping & MAP_FLYDIGI_BUTTONS) {
+		for (i = 0; xpad_btn_extra[i] >= 0; i++) {
+			input_set_capability(input_dev, EV_KEY, xpad_btn_extra[i]);
+		}
+	}
+
 	/*
 	 * This should be a simple else block. However historically
 	 * xbox360w has mapped DPAD to buttons while xbox360 did not. This
@@ -2300,7 +2340,7 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 	struct usb_device *udev = interface_to_usbdev(intf);
 	struct usb_xpad *xpad;
 	struct usb_endpoint_descriptor *ep_irq_in, *ep_irq_out;
-	int i, error;
+	int i, j, error;
 
 	if (intf->cur_altsetting->desc.bNumEndpoints != 2)
 		return -ENODEV;
@@ -2334,6 +2374,16 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 	xpad->udev = udev;
 	xpad->intf = intf;
 	xpad->mapping = xpad_device[i].mapping;
+
+	if (udev->product) {
+		for(j = 0; xpad_flavor[j].idVendor; j++) {
+			if (!strcmp(udev->product, xpad_flavor[j].product)) {
+				xpad->mapping |= xpad_flavor[j].mapping;
+				break;
+			}
+		}
+	}
+
 	xpad->xtype = xpad_device[i].xtype;
 	xpad->name = xpad_device[i].name;
 	xpad->quirks = xpad_device[i].quirks;

belozer · 2025-03-05T18:33:37Z

@blindedone1458 Thanks, with this patch, I see that the paddle buttons is working (via steam). Apex 4

But what to do about the Share button? Because Series controllers have it.

Fabianoshz · 2025-03-05T19:16:27Z

@blindedone1458 tbh I've set this up months ago and didn't bothered after that, having them being recognized a xbox elite could be good but it depends on ends up being merged on xpad.

My guess is that if you patch works we could maybe close this in favor of that and people can revisit this in the future in case the original patch gets merged for whatever reason.

blindedone1458 · 2025-03-05T20:41:59Z

For the Share button, are you referring to the Circle button? I honestly hadn't even considered the button as something that could be mapped originally (since it wasn't really doing much beyond controller functions) without Flydigi mapping software. I just made a change to the xpad patch to map it to a Share button:

diff --git a/xpad.c b/xpad.c
index d5a016e..0e8f73f 100644
--- a/xpad.c
+++ b/xpad.c
@@ -95,6 +95,7 @@
 #define MAP_SELECT_BUTTON		(1 << 3)
 #define MAP_PADDLES			(1 << 4)
 #define MAP_PROFILE_BUTTON		(1 << 5)
+#define MAP_FLYDIGI_BUTTONS		(1 << 6)
 
 #define DANCEPAD_MAP_CONFIG	(MAP_DPAD_TO_BUTTONS |			\
 				MAP_TRIGGERS_TO_BUTTONS | MAP_STICKS_TO_NULL)
@@ -421,6 +422,19 @@ static const struct xpad_device {
 	{ 0x0000, 0x0000, "Generic X-Box pad", 0, XTYPE_UNKNOWN }
 };
 
+// A "flavor" is an aftermarket variant of an existing model supporting
+// additional features.
+static const struct xpad_flavor {
+	u16 idVendor;
+	u16 idProduct;
+	char *product;
+	u8 mapping;
+} xpad_flavor[] = {
+	{ 0x045e, 0x028e, "Flydigi VADER3", MAP_PADDLES | MAP_FLYDIGI_BUTTONS },
+	{ 0x045e, 0x028e, "Flydigi VADER4", MAP_PADDLES | MAP_FLYDIGI_BUTTONS },
+	{ 0x0000, 0x0000, NULL, 0 }
+};
+
 /* buttons shared with xbox and xbox360 */
 static const signed short xpad_common_btn[] = {
 	BTN_A, BTN_B, BTN_X, BTN_Y,			/* "analog" buttons */
@@ -484,6 +498,13 @@ static const struct {int x; int y; } dpad_mapping[] = {
 	{0, 0}
 };
 
+/* used for extra buttons in addition to paddles on Flydigi Vader Pro 3*/
+static const signed short xpad_btn_extra[] = {
+	BTN_TRIGGER_HAPPY9, BTN_TRIGGER_HAPPY10, /* Z, C face buttons */
+	KEY_RECORD,			/* circle */
+	-1						/* terminating entry */
+};
+
 /*
  * Xbox 360 has a vendor-specific class, so we cannot match it with only
  * USB_INTERFACE_INFO (also specifically refused by USB subsystem), so we
@@ -940,6 +961,7 @@ static void xpad_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char *d
  *
  *	The used report descriptor was taken from:
  *		http://www.free60.org/wiki/Gamepad
+ *	Packet length for valid data is 20 bytes.
  */
 
 static void xpad360_process_packet(struct usb_xpad *xpad, struct input_dev *dev,
@@ -1012,6 +1034,17 @@ static void xpad360_process_packet(struct usb_xpad *xpad, struct input_dev *dev,
 		input_report_abs(dev, ABS_RZ, data[5]);
 	}
 
+	/* Additional buttons for Flydigi Vader Pro 3 presenting as 360 pad. */
+	if (xpad->mapping & MAP_FLYDIGI_BUTTONS) {
+		input_report_key(dev, BTN_TRIGGER_HAPPY10, data[19] & BIT(0));   // C
+		input_report_key(dev, BTN_TRIGGER_HAPPY9, data[19] & BIT(1));  // Z
+		input_report_key(dev, BTN_TRIGGER_HAPPY8, data[19] & BIT(3));   // Leftmost paddle (M2)
+		input_report_key(dev, BTN_TRIGGER_HAPPY7, data[19] & BIT(5));   // Second to leftmost (M4)
+		input_report_key(dev, BTN_TRIGGER_HAPPY5, data[19] & BIT(4));   // Second to rightmost (M3)
+		input_report_key(dev, BTN_TRIGGER_HAPPY6, data[19] & BIT(2));   // Rightmost paddle (M1)
+		input_report_key(dev, KEY_RECORD, data[20] & BIT(0));  // Circle
+	}
+
 	input_sync(dev);
 
 	/* XBOX360W controllers can't be turned off without driver assistance */
@@ -2246,6 +2279,13 @@ static int xpad_init_input(struct usb_xpad *xpad)
 			input_set_capability(input_dev, EV_KEY, xpad_btn_paddles[i]);
 	}
 
+	/* set up extra face buttons if the controller has them */
+	if (xpad->mapping & MAP_FLYDIGI_BUTTONS) {
+		for (i = 0; xpad_btn_extra[i] >= 0; i++) {
+			input_set_capability(input_dev, EV_KEY, xpad_btn_extra[i]);
+		}
+	}
+
 	/*
 	 * This should be a simple else block. However historically
 	 * xbox360w has mapped DPAD to buttons while xbox360 did not. This
@@ -2300,7 +2340,7 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 	struct usb_device *udev = interface_to_usbdev(intf);
 	struct usb_xpad *xpad;
 	struct usb_endpoint_descriptor *ep_irq_in, *ep_irq_out;
-	int i, error;
+	int i, j, error;
 
 	if (intf->cur_altsetting->desc.bNumEndpoints != 2)
 		return -ENODEV;
@@ -2334,6 +2374,16 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 	xpad->udev = udev;
 	xpad->intf = intf;
 	xpad->mapping = xpad_device[i].mapping;
+
+	if (udev->product) {
+		for(j = 0; xpad_flavor[j].idVendor; j++) {
+			if (!strcmp(udev->product, xpad_flavor[j].product)) {
+				xpad->mapping |= xpad_flavor[j].mapping;
+				break;
+			}
+		}
+	}
+
 	xpad->xtype = xpad_device[i].xtype;
 	xpad->name = xpad_device[i].name;
 	xpad->quirks = xpad_device[i].quirks;

blindedone1458 · 2025-03-05T20:46:44Z

As for your PR, I think it is good to have but just that the CapabilityMap doesn't need all those Mappings in it. Could have a basic mapping in it for the C and Z buttons since the Xbox Elite / Series controllers don't have a C or Z:

mapping:
  - name: C Button
    target_event:
      gamepad:
        button: LeftStick
    source_events:
      - gamepad:
          button: LeftPaddle3
  - name: Z Button
    target_event:
      gamepad:
        button: RightStick
    source_events:
      - gamepad:
          button: RightPaddle3

pastaq · 2025-03-05T21:34:22Z

Can someone post a picture of the controller with all the buttons labeled for context?

belozer · 2025-03-05T21:48:29Z

For the Share button, are you referring to the Circle button

@blindedone1458 Yes, that's correct. Circle is the FN button. I didn't think that data was also transmitted. But I saw
KEY_RECORD (BTN_TRIGGER_HAPPY11 in first version) in your patch.

I think we need to try mapping it to the "Share" button.

cc @pastaq

Apex 4

Vader 4

This is necessary for taking screenshots and full mapping of the Xbox Elite controller.

belozer · 2025-03-05T22:24:16Z

Ohh... I forgot. The "Share" button only exists on the Xbox Series controller. On the Xbox Elite 2 controller, this button switches profiles. I have not used the controller in a long time...

But at the same time, when you look at the Steam interface you can see this button.

Xbox Series

Xbox Elite 2

But will cool mapping FN to it if possible.

belozer · 2025-03-05T23:25:51Z

@blindedone1458 thanks! It works #308 (comment)

Now Steam recognizes FN as the Screenshot/Share button, tested on Flydigi Apex 4. Paddle Buttons also works and recognized in Steam (by using InputPlumber).

belozer · 2025-03-06T09:53:44Z

@pastaq a gamepad with paddle button layout for context. I have marked it in orange.

Flydigi Vader 3/4 (Apex 4 the same)

pastaq · 2025-03-06T13:43:37Z

Interesting.

Buttons C and Z are going to be a challenge as there isn't a normal function for them on modern controllers. They are part of the original dinput spec and produce valid codes (BTN_C/BTN_Z). The original Xbox controller has them as well as things like the sidewinder and the Sega Saturn controller. They have fallen out of favor since the 360 came out. It feels incorrect to map them to happy trigger. We also haven't fully decided what to do with them in InputPlumber as they fit into a weird spot where they aren't really a standard capability or button like abxy are, despite being an extension of that.

belozer · 2025-03-10T10:21:59Z

It seems that these buttons (C, Z) need to be connected to keyboard events in the current situation.

E.g.

Home, End
Page Up, Page Down
Left Alt, Right Alt

belozer · 2025-03-10T10:25:57Z

The current solution for Apex 4 meets 90% of the needs. The remaining 10% is the gyroscope.

Also ability to change at least the backlight color, but that's another story.

Fabianoshz mentioned this pull request Mar 5, 2025

Successfully sending out the extra buttons paroj/xpad#268

Open

feat(Flydigi): Add support for flydigi vader 3/4 pro

4fac759

Fabianoshz force-pushed the add-flydigi-vader-pro-support branch from 75aa6d7 to 4fac759 Compare March 5, 2025 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Flydigi): Add support for flydigi vader 3/4 pro #308

feat(Flydigi): Add support for flydigi vader 3/4 pro #308

Fabianoshz commented Mar 5, 2025

blindedone1458 commented Mar 5, 2025

belozer commented Mar 5, 2025 •

edited

Loading

Fabianoshz commented Mar 5, 2025

blindedone1458 commented Mar 5, 2025

blindedone1458 commented Mar 5, 2025

pastaq commented Mar 5, 2025

belozer commented Mar 5, 2025 •

edited

Loading

belozer commented Mar 5, 2025 •

edited

Loading

belozer commented Mar 5, 2025 •

edited

Loading

belozer commented Mar 6, 2025 •

edited

Loading

pastaq commented Mar 6, 2025

belozer commented Mar 10, 2025 •

edited

Loading

belozer commented Mar 10, 2025

feat(Flydigi): Add support for flydigi vader 3/4 pro #308

Are you sure you want to change the base?

feat(Flydigi): Add support for flydigi vader 3/4 pro #308

Conversation

Fabianoshz commented Mar 5, 2025

blindedone1458 commented Mar 5, 2025

belozer commented Mar 5, 2025 • edited Loading

Fabianoshz commented Mar 5, 2025

blindedone1458 commented Mar 5, 2025

blindedone1458 commented Mar 5, 2025

pastaq commented Mar 5, 2025

belozer commented Mar 5, 2025 • edited Loading

belozer commented Mar 5, 2025 • edited Loading

belozer commented Mar 5, 2025 • edited Loading

belozer commented Mar 6, 2025 • edited Loading

pastaq commented Mar 6, 2025

belozer commented Mar 10, 2025 • edited Loading

belozer commented Mar 10, 2025

belozer commented Mar 5, 2025 •

edited

Loading

belozer commented Mar 5, 2025 •

edited

Loading

belozer commented Mar 5, 2025 •

edited

Loading

belozer commented Mar 5, 2025 •

edited

Loading

belozer commented Mar 6, 2025 •

edited

Loading

belozer commented Mar 10, 2025 •

edited

Loading